GNOME Bugzilla – Bug 623017
Add introspection support
Last modified: 2013-09-14 16:54:27 UTC
See http://live.gnome.org/GnomeGoals/AddGObjectIntrospectionSupport and http://live.gnome.org/GObjectIntrospection/AutotoolsIntegration . For examples see http://bugzilla-attachments.gnome.org/attachment.cgi?id=164277 or http://bugzilla-attachments.gnome.org/attachment.cgi?id=161767 .
Created attachment 172328 [details] [review] Add introspection support It work fine (example of use in Bug 632109).
Created attachment 172789 [details] [review] Add introspection support merge with HEAD add some annotations
I'm not an introspection expert, but the patch looks well written to me. Thanks! Committed to master branch: http://git.gnome.org/browse/evolution-data-server/commit/?id=63744d4e49d8c91d99f61a51685bc6379c8968a6 Leaving the bug open since this only covers libecal and bits of libedataserver, but it's a good start nonetheless.
(In reply to comment #3) > I'm not an introspection expert, but the patch looks well written to me. > Thanks! > > Committed to master branch: > http://git.gnome.org/browse/evolution-data-server/commit/?id=63744d4e49d8c91d99f61a51685bc6379c8968a6 > > Leaving the bug open since this only covers libecal and bits of libedataserver, > but it's a good start nonetheless. m4/introspection.m4 was not commited (It was in original patch). e-d-s require gobject-introspection to build without it.
Hmm, why was it added to .gitignore then? Anyway, fixed in: http://git.gnome.org/browse/evolution-data-server/commit/?id=6d1457e4c983bb26f8db84cdad6bdf1aed294d7b
I'm trying to jhbuild e-d-s git master (and had ran "make distclean") but I get this - is it "intended" as introspection support is not yet finished? Making all in libecal make[3]: Entering directory `/home/andre/svn-gnome/evolution-data-server/calendar/libecal' make all-am make[4]: Entering directory `/home/andre/svn-gnome/evolution-data-server/calendar/libecal' GISCAN ECalendar-1.2.gir Couldn't find include 'EDataServer-1.2.gir' (search path: ['/home/andre/opt-gnome/share/gir-1.0', '/usr/share/gir-1.0']) make[4]: *** [ECalendar-1.2.gir] Error 1 make[4]: Leaving directory `/home/andre/svn-gnome/evolution-data-server/calendar/libecal'
Created attachment 173615 [details] [review] introspection: add search path for EDataServer-1.2.gir > is it "intended" as introspection support is not yet finished? no. This patch should fix it.
Maxim: I would use ECalendar_1_2_gir_SCANNERFLAGS instead of INTROSPECTION_SCANNER_ARGS in this case. Bug 634174 would help too.
Comment on attachment 173615 [details] [review] introspection: add search path for EDataServer-1.2.gir Already fixed by bug 634167. What is left now to keep this bug opened?
This might be slightly unrelated. I am trying to generate the binding for Vala with: vapigen --library=EDataServer-1.2 ./libedataserver/EDataServer-1.2.gir and it fails with the following error: EDataServer-1.2.gir:1670.9-1670.8: error: `SoapResponse' already contains a definition for `from_string' EDataServer-1.2.gir:1642.9-1642.8: note: previous definition of `from_string' was here I suspect from_string might be already defined in one of the base clases (Glib Object?). Commenting out the definition of the from_string method on the GIR files allows me to build the binding. Ideas?
Introspection support has been added. Doesn't seem like there's anything left to do here so I'm closing this to get it off the GNOME 3 blocker list.
Created attachment 179912 [details] [review] Improve annotations on a couple of methods in libebook This enhances introspection support (without these comments many methods are mark as not introspect-able by g-ir-scanner).
Thanks for the patch. Committed it for 2.32.2 and 2.91.90. http://git.gnome.org/browse/evolution-data-server/commit/?id=424b5b4e88737f47a2968b716d9cee39aa095f75 http://git.gnome.org/browse/evolution-data-server/commit/?h=gnome-2-32&id=12116eb27db8691d5fd9656a95e35cdceb07d030