After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622821 - Structural navigation should not move to empty sections
Structural navigation should not move to empty sections
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.31.x
Other All
: Normal normal
: 2.32.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2010-06-26 18:59 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2010-09-20 10:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (1.18 KB, patch)
2010-06-26 19:01 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2010-06-26 18:59:29 UTC 
Steps to reproduce:

1. View news.google.com
2. Press H

Eventually, you will run across headings for which Orca fails to speak the text.

The problem is that the page has empty sections within the heading, i.e.:

<h2><div></div>Blah blah blah</h2>

Patch to follow.
Comment 1 Joanmarie Diggs (IRC: joanie) 2010-06-26 19:01:45 UTC 
Created attachment 164694 [details] [review]
proposed fix

Works for me. Pylints to a 10. Bill, please test. Thanks!
Comment 2 Joanmarie Diggs (IRC: joanie) 2010-06-26 19:27:43 UTC 
Comment on attachment 164694 [details] [review]
proposed fix

Bill confirmed via private email that this solved the problem for him. (Thanks Bill!)

It's a safe, targeted fix so I've gone ahead and committed it to master:
http://git.gnome.org/browse/orca/commit/?id=beea34a4096f85188258af8db58f5ae870dd74f2