After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622770 - needs to document when floating variants are consumed
needs to document when floating variants are consumed
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gvariant
unspecified
Other Linux
: Normal minor
: ---
Assigned To: Allison Karlitskaya (desrt)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2010-06-25 22:36 UTC by Christian Persch
Modified: 2010-08-14 02:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch 1/3 (6.91 KB, patch)
2010-07-27 14:54 UTC, Simon McVittie 		none Details | Review
patch 2/3 (1.72 KB, patch)
2010-07-27 14:54 UTC, Simon McVittie 		none Details | Review
patch 3/3 (2.13 KB, patch)
2010-07-27 14:54 UTC, Simon McVittie 		none Details | Review

Description Christian Persch 2010-06-25 22:36:55 UTC 
The gvariant docs aren't very clear on when a floating gvariant is consumed.

E.g. g_variant_new_variant() does ref_sink(), so consumes a floating variant, but the docs don't mention this.

Also for g_variant_new_maybe(), new_array(), etc.

And for g_variant_new () with "@" or "v".
Comment 1 Simon McVittie 2010-07-27 14:54:10 UTC 
Created attachment 166651 [details] [review]
patch 1/3
Comment 2 Simon McVittie 2010-07-27 14:54:23 UTC 
Created attachment 166652 [details] [review]
patch 2/3
Comment 3 Simon McVittie 2010-07-27 14:54:38 UTC 
Created attachment 166653 [details] [review]
patch 3/3
Comment 4 Matthias Clasen 2010-08-14 02:44:26 UTC 
Thanks, committed