GNOME Bugzilla – Bug 622504
[GstPad] Provide more fine-grained linking methods
Last modified: 2010-06-23 16:44:39 UTC
Currently gst_pad_link unconditionally does a series of checks that could be avoided when the caller knows they will never fail. The following patches: * add a new method for pad linking which allows to chose which checks could be done at link time * add a new utility method for link element pads which allows to chose which checks should be done at link time * does a check-less link when gstghostpad links its internal pad to the target.
Created attachment 164408 [details] [review] GstPad: Add new pad linking method with configurable checks. To be used for cases where we don't need all checks to be validated. API: gst_pad_link_full API: GstPadLinkCheck
Created attachment 164409 [details] [review] gstutils: New gst_element_link_pads_full method Links the elements with the specified pad linking checks.
Created attachment 164410 [details] [review] gstghostpad: We don't need any checks when linking target pad
looks simple and effective, no objections from me for pushing it.
Comment on attachment 164408 [details] [review] GstPad: Add new pad linking method with configurable checks. >+typedef enum { >+ GST_PADLINK_CHECK_NOTHING = 1 << 0, >+ GST_PADLINK_CHECK_HIERARCHY = 1 << 1, >+ GST_PADLINK_CHECK_TEMPLATE_CAPS = 1 << 2, >+ GST_PADLINK_CHECK_CAPS = 1 << 3, >+} GstPadLinkCheck; >+... >+ * GST_PADLINK_CHECK_DEFAULT: >+ ... >+#define GST_PADLINK_CHECK_DEFAULT (GST_PADLINK_CHECK_HIERARCHY | GST_PADLINK_CHECK_CAPS) Minor nitpick: I think that should be GST_PAD_LINK_CHECK_* everywhere here.
And please add Since: 0.10.30 markers to the gtk-doc chunks for the new functions/enums/defines
Created attachment 164412 [details] [review] GstPad: Add new pad linking method with configurable checks. To be used for cases where we don't need all checks to be validated. API: gst_pad_link_full API: GstPadLinkCheck
Created attachment 164413 [details] [review] gstutils: New gst_element_link_pads_full method Links the elements with the specified pad linking checks. API:gst_element_link_pads_full
Created attachment 164414 [details] [review] gstghostpad: We don't need any checks when linking target pad
commit 4a999b5e43b5cd9f6bc9b2d0615d8491cee23ec0 Author: Edward Hervey <bilboed@bilboed.com> Date: Wed Jun 23 17:24:07 2010 +0200 gstghostpad: We don't need any checks when linking target pad https://bugzilla.gnome.org/show_bug.cgi?id=622504 commit 5faf5620f3756e16130d9a6dcde77070c02b8f38 Author: Edward Hervey <bilboed@bilboed.com> Date: Wed Jun 23 17:00:17 2010 +0200 gstutils: New gst_element_link_pads_full method Links the elements with the specified pad linking checks. API:gst_element_link_pads_full https://bugzilla.gnome.org/show_bug.cgi?id=622504 commit 625c4e2d80f02ed54eb8bfd2ff3cde41da06f9da Author: Edward Hervey <bilboed@bilboed.com> Date: Wed Jun 23 16:45:19 2010 +0200 GstPad: Add new pad linking method with configurable checks. To be used for cases where we don't need all checks to be validated. API: gst_pad_link_full API: GstPadLinkCheck https://bugzilla.gnome.org/show_bug.cgi?id=622504