After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622285 - Allow building with Gtk+-3.0
Allow building with Gtk+-3.0
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on: 572332 612491
Blocks:
 
 
Reported: 2010-06-21 12:38 UTC by Florian Müllner
Modified: 2014-06-08 19:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Allow building with Gtk+-3.0 (2.29 KB, patch)
2010-06-21 12:38 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2010-06-21 12:38:30 UTC 
Add a configure switch to compile with Gtk+-3.0. Obviously depends on both bug 572332 and bug 612491.
Comment 1 Florian Müllner 2010-06-21 12:38:33 UTC 
Created attachment 164214 [details] [review]
Allow building with Gtk+-3.0

Add a configure switch to select the Gtk+ version to build with. The
default is to build against Gtk+-2.0 >= 2.20.0.
Comment 2 Craig Keogh 2010-07-03 04:05:17 UTC 
To compile with Gtk+3.0, GdkRegion needs to be removed. See bug 623445 from gnome-control-center for some info.

(The attachments to bug 572332 and bug 612491 don't deal with GdkRegion)
Comment 3 Florian Müllner 2010-07-03 04:12:59 UTC 
(In reply to comment #2)
> To compile with Gtk+3.0, GdkRegion needs to be removed. See bug 623445 from
> gnome-control-center for some info.

... or better bug 587991 - I didn't try to apply the patch to metacity yet, but adapting it should be relatively painless (mutter is a friendly fork of metacity)
Comment 4 Craig Keogh 2010-07-03 08:17:38 UTC 
Is it necessary to maintain backwards compatibility with GdkRegion? mutter did, defining a new type MetaRegion.
Comment 5 Florian Müllner 2010-07-03 10:59:51 UTC 
(In reply to comment #4)
> Is it necessary to maintain backwards compatibility with GdkRegion? mutter did,
> defining a new type MetaRegion.

This question is the main reason why I haven't adapted that patch yet :)
For mutter it is a hard requirement - the same branch is used for both GNOME's unstable development and Meego's stable releases. It's definitively easier for metacity to bump version requirements - the GdkRegion/cairo_region_t change is Gtk+-3 only though, so this is a question for the maintainers. If depending on Gtk+-3 is OK, then there is a previous patch version using #ifdefs which could be adapted.
Comment 6 Diego González 2010-07-04 17:33:22 UTC 
You will need to modify some more things other than just adding a configure switch and moving away from GdkRegion.

There are some parts that are using the GTK_WIDGET macros which have been removed and also the GtkType which is gone for good.
Comment 7 Florian Müllner 2010-07-04 17:54:00 UTC 
(In reply to comment #6)
> You will need to modify some more things other than just adding a configure
> switch and moving away from GdkRegion.
> 
> There are some parts that are using the GTK_WIDGET macros which have been
> removed and also the GtkType which is gone for good.

I know, that's why the bug depends on bug 572332 and bug 612491 - no need to duplicate the effort here :-)
Comment 8 Thomas Thurman 2010-07-14 13:02:19 UTC 
Review of attachment 164214 [details] [review]:

Makes sense.  Committed.
Comment 9 André Klapper 2011-03-03 20:51:56 UTC 
[Removing GNOME3.0 target as decided in release-team meeting on March 03, 2011. "nice-to-have" categorisation for GNOME3.0]