GNOME Bugzilla – Bug 622149
--disable-regex breaks glib2 build
Last modified: 2012-02-27 03:22:56 UTC
Created attachment 164104 [details] build logs with and without --disable-regex I'm cross-compiling glib2 2.24.1 to Windows on openSUSE Build Service. With the --disable-regex configure option, the build breaks Creating library file: .libs/libglib-2.0.dll.aCannot export g_match_info_expand_references: symbol not defined Cannot export g_match_info_fetch: symbol not defined [..snip..] Cannot export g_regex_check_replacement: symbol not defined Cannot export g_regex_error_quark: symbol not defined [..snip..]
Yeah, I'm inclined to remove that configure option. Why do you try to build glib without regex support, anyway ?
On Windows I ship the giant GTK+/PyGTK stack with my tiny cross-platform application, and to shrink each dependency I've been trying various options including trying ./configure options, CFLAG=-Os, etc. So maybe the whole system would work with --disable-regex, but maybe it wouldn't.
Created attachment 207368 [details] [review] regex: Remove --disable-regex option
One question to ask before we delete code - who introduced it, and and why? git annotate says: commit 0196d639753247cb0d8aca289155154ef6daa561 Author: Marco Barisione <marco@barisione.org> Date: Thu Mar 15 13:01:31 2007 +0000 And the originating bug is: https://bugzilla.gnome.org/show_bug.cgi?id=50075 Scanning through the discussion there appears to have been no rationale for adding a configure option. So let's just remove it.
Review of attachment 207368 [details] [review]: Looks right.
The following fix has been pushed: d706345 regex: Remove --disable-regex option
Created attachment 208467 [details] [review] regex: Remove --disable-regex option