After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621998 - Should stop using ShareWithTube()
Should stop using ShareWithTube()
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Tube
2.29.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
Depends on: 621997
Blocks:
 
 
Reported: 2010-06-18 13:45 UTC by Guillaume Desmottes
Modified: 2010-06-21 12:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/vino-621998 (7.50 KB, patch)
2010-06-18 13:46 UTC, Guillaume Desmottes 		reviewed Details | Review

Description Guillaume Desmottes 2010-06-18 13:45:25 UTC 
Once Vino will be in the Handler future (bug #621997) Empathy should stop calling the ShareWithTube() D-Bus method and just request the stream tube using the channel dispatcher.
Comment 1 Guillaume Desmottes 2010-06-18 13:46:28 UTC 
Created attachment 164005 [details] [review]
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/vino-621998

 libempathy-gtk/empathy-share-my-desktop.c |  231 ++++-------------------------
 1 files changed, 28 insertions(+), 203 deletions(-)
Comment 2 Danielle Madeley 2010-06-21 10:59:51 UTC 
Review of attachment 164005 [details] [review]:

Looks good.
Comment 3 Guillaume Desmottes 2010-06-21 12:19:41 UTC 
Merged to master.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.