After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621879 - update for glib api changes in 2.25.9
update for glib api changes in 2.25.9
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] GIO
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 621871 (view as bug list)
Depends on:
Blocks: 621874
 
 
Reported: 2010-06-17 12:20 UTC by Matthias Clasen
Modified: 2010-06-19 04:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (6.32 KB, patch)
2010-06-17 12:20 UTC, Matthias Clasen 		needs-work Details | Review

Description Matthias Clasen 2010-06-17 12:20:48 UTC 
Created attachment 163905 [details] [review]
patch

When I release glib 2.25.9 today or tomorrow, the api changes in gdbus will cause problems for apps which have already started using gdbus.

Here is a patch for nautilus - note that it is not tested at all.
Comment 1 Claudio Saavedra 2010-06-17 13:04:24 UTC 
Review of attachment 163905 [details] [review]:

Patch fails to build, but fix is trivial.. didn't test it though.

::: src/nautilus-application.c
@@ +614,2 @@
 	g_variant_get (variant, "(&o)", &session_path);
 

This is missing the GCancellable parameter.

@@ +619,3 @@
+				  CK_NAME,
+				  session_path,
+				  CK_INTERFACE ".Session",

+ 				  NULL,
Comment 2 Christian Persch 2010-06-17 15:54:47 UTC 
+pk_proxy_appeared_cb (GObject      *source,
+                      GAsyncResult *res,
 		      gpointer user_data)
 {
         ActivateParametersInstall *parameters_install = user_data;
 	char *mime_type;
 	char *error_message;
 	GtkWidget *dialog;
+        GDBusProxy *proxy;
+
+        proxy = g_dbus_proxy_new_for_bus_finish (res, NULL);
 
Should check for error (proxy == NULL) here.
Comment 3 Cosimo Cecchi 2010-06-17 16:59:50 UTC 
Thanks Matthias, I pushed to master a patch based on yours that checks for error != NULL and builds correctly.

Closing as FIXED.
Comment 4 Craig Keogh 2010-06-19 04:21:00 UTC 
*** Bug 621871 has been marked as a duplicate of this bug. ***