GNOME Bugzilla – Bug 621767
[enh] add proxy to nm-connection-editor [th/proxy-bgo621767]
Last modified: 2016-12-16 14:09:23 UTC
When switching a network (either by interface or VPN) that requires a proxy, the GConf configuration should switch as well. I consider that kind of basic functionality, just like ip address, DNS server; requiring the user to do any of those steps in order to be able to use the network is burdensome. Besides, at least GNOME proxy settings already provide the concept of locations.
Adding an extra tab to the connection editor that allows specifying the GNOME proxy settings to switch to when using that connection would work nicely.
It's being forked on ...
*** Bug 583431 has been marked as a duplicate of this bug. ***
The central GNOME proxy settings should probably just die. It's entirely the wrong model. Further thoughts at https://wiki.gnome.org/Projects/NetworkManager/Proxies
Awesome! Finally a _real_ HTTP proxy solution! Looking forward to it...
this was implemented in NetworkManager server side with 1.5.3 The main commit was here: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=6e9abe3d88148b92978400c5155c48ec29372f2e It integerates proxy settings with pac-runner. What is still missing is nm-connection-editor integration. For now, the new API is only exposed on D-Bus API and in nmcli. I re-purpose the bug for the latter.
btw, there were patches on the mailing list by Atul Anand (CC-ing). https://mail.gnome.org/archives/networkmanager-list/2016-August/msg00079.html I took them and applied them on a branch th/proxy-bgo621767, they would need some love. One ~problem~ is, that current master of nm-applet requires only libnm-1-2 API (while the proxy API is libnm-1-6). So we would either have to (a) branch off a nm-1-2 stable branch and bump the required library version on master to 1.6 (b) add a capability workaround, preferably using runtime-detection of compile time. Of course, as time goes by, (a) becomes more and more attractive.
using runtime-detection of compile time. ^^ OR
> nm-c-e/proxy: Support proxy handling similar to nmcli. + g_file_get_contents (filename, &script, &len, NULL); + if ( len > 100000 + || !strstr (script, "FindProxyForURL") Maybe we should show a message telling why the file is not valid. Pushed a fixup, otherwise looks good!
(In reply to Beniamino Galvani from comment #9) > > nm-c-e/proxy: Support proxy handling similar to nmcli. > > + g_file_get_contents (filename, &script, &len, NULL); > + if ( len > 100000 > + || !strstr (script, "FindProxyForURL") > > Maybe we should show a message telling why the file is not valid. In libnm, I did https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=92ea1bdb06eda77f3ec5bf6b8cd3bb54da739c77 so that nm_connection_verify() rejects such configurations. Hence, I pushed a fixup commit that get's rid of the check in nm-c-e. Note however, there is still a bug that changing the script doesn't trigger a re-verification of the input values. Compare that with e.g. ethernet's cloned-mac-address input-field: while typing, the connection is validated and the "Save" button is disabled accordingly.
(In reply to Thomas Haller from comment #10) > Note however, there is still a bug that changing the script doesn't trigger > a re-verification of the input values. Compare that with e.g. ethernet's > cloned-mac-address input-field: while typing, the connection is validated > and the "Save" button is disabled accordingly. fixed too.
merged to master: https://git.gnome.org/browse/network-manager-applet/commit/?id=56033f802d7bfdb91d3c0f60e5973979228f159e Thanks, Atul