After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621685 - Add gdk_device_manager_get_client_pointer() for getting main core pointer
Add gdk_device_manager_get_client_pointer() for getting main core pointer
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
2.90.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-06-15 18:33 UTC by Carlos Garnacho
Modified: 2010-06-24 00:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GdkDeviceManager: Add gdk_device_manager_get_client_pointer(). (11.13 KB, patch)
2010-06-15 18:36 UTC, Carlos Garnacho
accepted-commit_now Details | Review

Description Carlos Garnacho 2010-06-15 18:33:20 UTC
I'm attaching a patch that implements that function, resorting to XIGetClientPointer() in XI2, and to the core_pointer as usual for other device managers, this is a better replacement to gdk_display_get_core_pointer(), for the little usecases there's no GdkDevice around.
Comment 1 Carlos Garnacho 2010-06-15 18:36:54 UTC
Created attachment 163713 [details] [review]
GdkDeviceManager: Add gdk_device_manager_get_client_pointer().

This function makes a better replacement for
gdk_display_get_core_pointer(), wherever it might yet be needed, for
XI2 resorts to XIGetClientPointer(), for the others return the only
core pointer.
Comment 2 Matthias Clasen 2010-06-16 15:38:37 UTC
Review of attachment 163713 [details] [review]:

Looks good to me.
Comment 3 Carlos Garnacho 2010-06-24 00:25:42 UTC
Just pushed this to master, thanks!