After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621445 - [scrsaver] Adapt to GDBus API change
[scrsaver] Adapt to GDBus API change
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks: 621439 621874
 
 
Reported: 2010-06-13 14:06 UTC by Florian Müllner
Modified: 2010-06-18 16:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[scrsaver] Adapt to GDBus API change (3.58 KB, patch)
2010-06-13 14:06 UTC, Florian Müllner 		none Details | Review
[scrsaver] Adapt to GDBus API change (3.79 KB, patch)
2010-06-14 01:13 UTC, Florian Müllner 		none Details | Review
[scrsaver] Adapt to GDBus API change (4.00 KB, patch)
2010-06-17 20:50 UTC, Florian Müllner 		none Details | Review
[scrsaver] Adapt to GDBus API change (4.00 KB, patch)
2010-06-18 13:13 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2010-06-13 14:06:35 UTC 
See http://mail.gnome.org/archives/gtk-devel-list/2010-June/msg00079.html

The patch allows totem to compile with glib-master, but right now I'm getting an apparently unrelated runtime error (TotemStatusbar) on launch, so I'm afraid the patch is untested.
Comment 1 Florian Müllner 2010-06-13 14:06:39 UTC 
Created attachment 163509 [details] [review]
[scrsaver] Adapt to GDBus API change

The g_bus_watch_proxy/g_bus_unwatch_proxy API has been removed.
Instead, it is now possible to use well-known names for GBusProxy.
Comment 2 Christian Persch 2010-06-13 16:53:41 UTC 
Doing _sync calls in the object init method is wrong. We just went to a lot of trouble to make this completely async in evince!
Comment 3 Florian Müllner 2010-06-14 01:13:15 UTC 
Created attachment 163545 [details] [review]
[scrsaver] Adapt to GDBus API change

(In reply to comment #2)
> Doing _sync calls in the object init method is wrong. We just went to a lot of
> trouble to make this completely async in evince!

Makes sense. Updated patch to use async API.
Comment 4 Florian Müllner 2010-06-17 20:50:54 UTC 
Created attachment 163961 [details] [review]
[scrsaver] Adapt to GDBus API change

With bug 621905 fixed, I have finally been able to actually test the patch ...
Comment 5 Carlos Garcia Campos 2010-06-18 08:18:04 UTC 
Review of attachment 163961 [details] [review]:

::: lib/totem-scrsaver.c
@@ +251,3 @@
+	screensaver_update_dbus_presence (scr);
+
+	g_signal_connect (priv->gs_proxy, "notify::name-owner",

property name is g-name-owner
Comment 6 Florian Müllner 2010-06-18 13:13:15 UTC 
Created attachment 164004 [details] [review]
[scrsaver] Adapt to GDBus API change

(In reply to comment #5)
> property name is g-name-owner

Gah - prefixed properties ... Fixed.
Comment 7 Bastien Nocera 2010-06-18 15:11:51 UTC 
Carlos, chpe, can I get a review on that? If that's OK by you, then feel free to commit it, and update evince.
Comment 8 Carlos Garcia Campos 2010-06-18 15:49:27 UTC 
Looks good to me, Evince already updated (http://git.gnome.org/browse/evince/commit/?id=2297bff1e7d745f0f837d44feeda03244368d7f1)

Florian, please, push it to totem git too.
Comment 9 Florian Müllner 2010-06-18 16:00:58 UTC 
Attachment 164004 [details] pushed as 87b6378 - [scrsaver] Adapt to GDBus API change