After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621111 - gtk_init_with_args()'s GOptionEntry argument should be const
gtk_init_with_args()'s GOptionEntry argument should be const
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.90.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-06-09 13:28 UTC by Nick Schermer
Modified: 2010-06-10 02:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
constify gtk_init_with_args()'s GOptionEntry argument (2.25 KB, patch)
2010-06-09 17:19 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Nick Schermer 2010-06-09 13:28:09 UTC 
GOptionEntry in gtk_init_with_args() is not const, while it is in g_option_context_add_main_entries().

I think that can be fixed for Gtk 3.
Comment 1 Emmanuele Bassi (:ebassi) 2010-06-09 13:34:16 UTC 
it should be fixable on gtk-2-22 as well - constification of arguments it's allowed.
Comment 2 Javier Jardón (IRC: jjardon) 2010-06-09 17:19:34 UTC 
Created attachment 163216 [details] [review]
constify gtk_init_with_args()'s GOptionEntry argument

Also, I've used g types for consistency
Comment 3 Nick Schermer 2010-06-09 18:46:30 UTC 
Looks fine to me.
Comment 4 Javier Jardón (IRC: jjardon) 2010-06-10 02:40:51 UTC 
Comment on attachment 163216 [details] [review]
constify gtk_init_with_args()'s GOptionEntry argument

commit 785027751aaa0405342dcda0337dbd73d96a5d35
Comment 5 Javier Jardón (IRC: jjardon) 2010-06-10 02:41:12 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.