After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620978 - insert NAL7/8 always when encountering I frame
insert NAL7/8 always when encountering I frame
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.19
Other Linux
: Normal enhancement
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-08 15:12 UTC by Marc Leeman
Modified: 2010-06-14 10:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
always insert sps/pps when i frame is encountered (1.95 KB, patch)
2010-06-08 15:12 UTC, Marc Leeman
none Details | Review
include config-interval to time nal insertion (4.92 KB, patch)
2010-06-09 09:08 UTC, Marc Leeman
none Details | Review
h264parse: add option to insert SPS/PPS (6.26 KB, patch)
2010-06-09 13:44 UTC, Mark Nauwelaerts
none Details | Review
h264parse: add option to insert SPS/PPS (9.80 KB, patch)
2010-06-11 10:21 UTC, Mark Nauwelaerts
committed Details | Review

Description Marc Leeman 2010-06-08 15:12:37 UTC
Created attachment 163071 [details] [review]
always insert sps/pps when i frame is encountered

This small patch always enters nal types 7/8 sps/pps when an I frame is encountered instead of selectively.

It works more or less like the rtph246pay module.

This allows simple streaming of H264 over the network and have a stream that is always decodable on the other side without manually inserting the config parameters.

when using this in the parser element allows not only streaming rtp over the network; but also all kinds of elementary streams with or without transportstream encapsulation.

the rtph264pay module works with a timeout value (insert every second, 2 seconds); this patch always inserts it.

Please review carefully.

Considering the sheer number of posts on the mailing list recently; this could be a good addition.
Comment 1 Marc Leeman 2010-06-09 09:08:05 UTC
Created attachment 163176 [details] [review]
include config-interval to time nal insertion

Localised the changes better;

include config-interval parameter from rtph246pay to selectively insert the NAL7/8 types consistent with the rtph264pay and rtpmp4vpay modules.
Comment 2 Marc Leeman 2010-06-09 09:08:46 UTC
Comment on attachment 163071 [details] [review]
always insert sps/pps when i frame is encountered

newer patch obsoletes this
Comment 3 Mark Nauwelaerts 2010-06-09 13:44:00 UTC
Created attachment 163199 [details] [review]
h264parse: add option to insert SPS/PPS

Attached is a somewhat reworked/cleaned version.

In particular, it bears in mind that current approach only really/safely works when the output buffers are NALs (not AUs).
Comment 4 Mark Nauwelaerts 2010-06-11 10:21:24 UTC
Created attachment 163374 [details] [review]
h264parse: add option to insert SPS/PPS

Extended version of previous patch; now also inserts config NALUs when operating in access-unit mode.
Comment 5 Mark Nauwelaerts 2010-06-14 10:52:40 UTC
commit d6cab72552b5cd7cc37ee40bf877e49fda6c54ae
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Mon Jun 14 12:49:40 2010 +0200

    h264parse: add option to insert SPS/PPS in stream
    
    Add a new config-interval property to insert SPS and PPS at periodic intervals
    in the stream (when an IDR is encountered).
    
    Based on patch by <marc.leeman at gmail.com>
    
    Fixes #620978.