After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620943 - Add support for registering properties whose types are subtypes of GEnum and GFlags.
Add support for registering properties whose types are subtypes of GEnum and ...
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Martin Pitt
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-08 09:57 UTC by Tomeu Vizoso
Modified: 2012-04-05 08:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add support for registering properties whose types are subtypes of GEnum and GFlags. (1.23 KB, patch)
2010-06-08 09:57 UTC, Tomeu Vizoso 		needs-work Details | Review
Add support for GFlags properties (4.92 KB, patch)
2012-04-04 17:12 UTC, Martin Pitt 		committed Details | Review

Description Tomeu Vizoso 2010-06-08 09:57:02 UTC 
This fixes the test_enum tests that are failing right now.
Comment 1 Tomeu Vizoso 2010-06-08 09:57:04 UTC 
Created attachment 163035 [details] [review]
Add support for registering properties whose types are subtypes of GEnum and GFlags.
Comment 2 johnp 2010-09-23 16:28:16 UTC 
Comment on attachment 163035 [details] [review]
Add support for registering properties whose types are subtypes of GEnum and GFlags.

is this committed yet?  Free to commit but we don't have an issue with enums in the tests.
Comment 3 André Klapper 2012-02-22 12:00:50 UTC 
Tomeu: Was this committed or should this get in? 
(Trying to clean the accepted-commit_now queue a bit.)
Comment 4 Tomeu Vizoso 2012-02-22 13:56:19 UTC 
(In reply to comment #3)
> Tomeu: Was this committed or should this get in? 
> (Trying to clean the accepted-commit_now queue a bit.)

Looks like this needs tests before it can come in (it used to be tested in pygtk before).
Comment 5 Martin Pitt 2012-04-04 17:12:08 UTC 
Created attachment 211313 [details] [review]
Add support for GFlags properties

GEnum properties are already supported and covered by the tests.

GFlags properties indeed do not work. This patch provides support for those and adds tests. However, it's completely different from Tomeu's patch (as this was not sufficient, nor were some changes required), so I'd appreciate a peer review before I push this. Thanks in advance!
Comment 6 Tomeu Vizoso 2012-04-05 08:44:29 UTC 
Review of attachment 211313 [details] [review]:

Looks great
Comment 7 Martin Pitt 2012-04-05 08:56:53 UTC 
Pushed, thanks for the review!