After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620846 - [GtkBuilder transition] customratio_dialog
[GtkBuilder transition] customratio_dialog
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
GIT
Other Linux
: Normal enhancement
: 0.7.3
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks: f-spot-glade
 
 
Reported: 2010-06-07 14:10 UTC by Ruben Vermeersch
Modified: 2010-09-08 16:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
customratio_dialog migrated to GtkBuilder (15.18 KB, patch)
2010-06-21 01:11 UTC, ademir 		needs-work Details | Review
Custom Ratio Dialog migrated to GtkBuilder (16.21 KB, patch)
2010-06-21 20:48 UTC, ademir 		needs-work Details | Review
Kill the f-spot Glade-iator. (27.08 KB, patch)
2010-08-12 14:27 UTC, Paul Lange 		committed Details | Review

Description Ruben Vermeersch 2010-06-07 14:10:05 UTC 
The customratio_dialog needs to be migrated to GtkBuilder.
Comment 1 Ruben Vermeersch 2010-06-07 15:21:43 UTC 
Instructions on how to fix this can be found here:
http://f-spot.org/GtkBuilder_Transition

Please indicate below if you are working on this (and if you stopped working on it), so we can avoid duplicate work. If you are stuck, just ask for help on IRC or the mailing list.
Comment 2 ademir 2010-06-21 00:49:31 UTC 
Hi! I will migrate it.
Comment 3 ademir 2010-06-21 01:11:37 UTC 
Created attachment 164188 [details] [review]
customratio_dialog migrated to GtkBuilder

It's done.
Comment 4 Maxxer 2010-06-21 14:23:48 UTC 
Review of attachment 164188 [details] [review]:

please
1. place the .ui file under src/UI.Dialog/ui and name it accordingly to the others
2. add proper entry in po/POTFILES.in

thanks
Comment 5 ademir 2010-06-21 20:48:34 UTC 
Created attachment 164246 [details] [review]
Custom Ratio Dialog migrated to GtkBuilder

Ok, I think this meet requirements.
Comment 6 Ruben Vermeersch 2010-06-22 10:09:49 UTC 
Review of attachment 164246 [details] [review]:

You still need to change the [Glade.Widget] attributes. Otherwise it won't work (check this by going to an image, opening the edit tools, choose crop and then choose custom ration in the dropdown).
Comment 7 Paul Lange 2010-08-12 14:27:18 UTC 
Created attachment 167734 [details] [review]
Kill the f-spot Glade-iator.

Some extensions still need to be ported but f-spot.glade is gone!
Comment 8 Ruben Vermeersch 2010-08-12 14:34:30 UTC 
Comment on attachment 164246 [details] [review]
Custom Ratio Dialog migrated to GtkBuilder

Please mark old patches as obsolete.
Comment 9 Ruben Vermeersch 2010-08-12 14:39:57 UTC 
Attachment 167734 [details] pushed as d32de38 - Kill the f-spot Glade-iator.

Fantastic, thanks!