After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620843 - [GtkBuilder transition] mail_dialog
[GtkBuilder transition] mail_dialog
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
GIT
Other Linux
: Normal enhancement
: 0.7.0
Assigned To: Paul Lange
F-spot maintainers
Depends on:
Blocks: f-spot-glade
 
 
Reported: 2010-06-07 14:08 UTC by Ruben Vermeersch
Modified: 2010-06-14 15:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Convert Mail Dialog to GtkBuilder (56.72 KB, patch)
2010-06-09 21:54 UTC, Paul Lange 		committed Details | Review

Description Ruben Vermeersch 2010-06-07 14:08:31 UTC 
The mail_dialog needs to be migrated to GtkBuilder.
Comment 1 Ruben Vermeersch 2010-06-07 15:21:46 UTC 
Instructions on how to fix this can be found here:
http://f-spot.org/GtkBuilder_Transition

Please indicate below if you are working on this (and if you stopped working on it), so we can avoid duplicate work. If you are stuck, just ask for help on IRC or the mailing list.
Comment 2 Paul Lange 2010-06-09 20:09:00 UTC 
I'll work on this.
Comment 3 Ruben Vermeersch 2010-06-09 20:18:28 UTC 
Cool! Go for it!
Comment 4 Paul Lange 2010-06-09 21:54:24 UTC 
Created attachment 163239 [details] [review]
Convert Mail Dialog to GtkBuilder
Comment 5 Paul Lange 2010-06-09 21:56:21 UTC 
Converted the dialog like described on the website.

Furthermore:
- cleaned up whitespaces and tabs a bit
- Added an icon to the 'Create Mail' button.
Comment 6 Ruben Vermeersch 2010-06-14 15:58:40 UTC 
Attachment 163239 [details] pushed as 688efaa - Convert Mail Dialog to GtkBuilder


Very clean patch, merged before freeze because I want to look into the emailing
bug (bug 621117) and I prefer to avoid conflicts.

Quality stuff like this is always welcome, keep it coming!