After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620839 - [GtkBuilder transition] single_view
[GtkBuilder transition] single_view
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
GIT
Other Linux
: Normal enhancement
: 0.7.1
Assigned To: Nick Van Eeckhout
F-spot maintainers
Depends on: 620845
Blocks: f-spot-glade
 
 
Reported: 2010-06-07 14:06 UTC by Ruben Vermeersch
Modified: 2010-06-22 20:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
migrate single_view window from libglade to gtkbuilder (25.29 KB, patch)
2010-06-11 19:42 UTC, Nick Van Eeckhout 		none Details | Review
migrate single_view window from libglade to gtkbuilder (45.98 KB, patch)
2010-06-11 20:43 UTC, Nick Van Eeckhout 		none Details | Review
migrate single_view window and viewer_preferences dialog from libglade to gtkbuilder (42.43 KB, patch)
2010-06-14 21:37 UTC, Nick Van Eeckhout 		none Details | Review
migrate single_view window from libglade to gtkbuilder (76.43 KB, patch)
2010-06-14 21:54 UTC, Nick Van Eeckhout 		committed Details | Review

Description Ruben Vermeersch 2010-06-07 14:06:58 UTC 
The single_view needs to be migrated to GtkBuilder.
Comment 1 Ruben Vermeersch 2010-06-07 15:21:45 UTC 
Instructions on how to fix this can be found here:
http://f-spot.org/GtkBuilder_Transition

Please indicate below if you are working on this (and if you stopped working on it), so we can avoid duplicate work. If you are stuck, just ask for help on IRC or the mailing list.
Comment 2 Nick Van Eeckhout 2010-06-10 20:16:05 UTC 
I'll try to tackle this one
Comment 3 Nick Van Eeckhout 2010-06-11 19:42:12 UTC 
Created attachment 163423 [details] [review]
migrate single_view window from libglade to gtkbuilder
Comment 4 Nick Van Eeckhout 2010-06-11 20:43:35 UTC 
Created attachment 163431 [details] [review]
migrate single_view window from libglade to gtkbuilder
Comment 5 Nick Van Eeckhout 2010-06-13 15:48:40 UTC 
Comment on attachment 163431 [details] [review]
migrate single_view window from libglade to gtkbuilder

not complete yet. There's a nested class with ui that still needs to be migrated.
Comment 6 Nick Van Eeckhout 2010-06-14 21:37:02 UTC 
Created attachment 163634 [details] [review]
migrate single_view window and viewer_preferences dialog from libglade to gtkbuilder

I had to change the id of the window in code to match the id in ui and pointed everything to the property instead of the private field.
Comment 7 Nick Van Eeckhout 2010-06-14 21:54:45 UTC 
Created attachment 163635 [details] [review]
migrate single_view window from libglade to gtkbuilder

f-spot.glade was missing
Comment 8 Ruben Vermeersch 2010-06-18 18:19:10 UTC 
Will review/merge this once bug 620845 has landed. A quick look shows me that it's good though. Nice work!
Comment 9 Ruben Vermeersch 2010-06-22 20:19:30 UTC 
Merged, now that the viewer_preferences patch has landed. Great work Nick.