GNOME Bugzilla – Bug 620838
[GtkBuilder transition] tag_selection_dialog
Last modified: 2010-08-02 13:12:23 UTC
The tag_selection_dialog needs to be migrated to GtkBuilder.
Instructions on how to fix this can be found here: http://f-spot.org/GtkBuilder_Transition Please indicate below if you are working on this (and if you stopped working on it), so we can avoid duplicate work. If you are stuck, just ask for help on IRC or the mailing list.
I would like to work on this. I will strive to complete it by end of today or tomorrow. Thank you for making these tasks simple for new contributors such as myself.
Allright, go for it! Feel free to ask for help if you're stuck!
I've been stuck on the build step in your instructions. It can't find the package gtk-sharp-2.0.
I had to install gkt-sharp2, but now it can't find the package gnome-keyring-sharp-1.0.
Which distro do you use? Most likely you need to install development packages, in Fedora they're called packagename-devel.
I'm using Ubuntu Lucid.
Then "sudo apt-get build-dep f-spot" should help.
Thanks. I thought I did that since it's right there in the instructions, but guess I didn't since that helped. But know it needs the package unique-1.0.
If the script says you need unique-1.0 you have to install it in order to build f-spot! Also remeber, if you want to build software you'll also need the development files. To find them simply append an "-dev" to the package name.
Thanks again. I know that I would need the packages. My problem is that which package to install is not obvious to me. When it said I need the package unique-1.0, I tried "sudo apt-get install unique-1.0" to no avail. Doing a search on unique-1.0 came up with libunique. Using your suggestion of appending -dev, I found that to work.
In line 25 of src/UI.Dialog/TagSelectionDialog.cs, what was int response = this.Dialog.Run (); would have been changed to int response = this.Run (); if I blindly followed the instructions. That would have called the TagSelectionDialog Run function inside of that function, instead of the base class's Run function. Luckily, they have different return types and throw an error, otherwise it would have gone unnoticed by me, and infinite recursion! Yay! It's now int response = base.Run (); The instructions now say to attach the .patch file to the bug. Even though it says it's that simple, I'm not even sure what attaching a file to a bug means.
Eric, great to hear that you finished the conversion! A patch is a file which includes all changes you made and makes it easy for others to apply them too. If you created it like described on the webpage, simply click "Add an attachment" at the bottom of this page and select yout patch-file. A formular will open, please select the checkbox for patch there. After that someone will will review your patch. Thanks for your work.
Created attachment 163273 [details] [review] Patch for tag_selection_dialog migrated to GtkBuilder
Thanks. That was fun. I'd like to do more. Any suggestions of where I could look to find things to help with?
(In reply to comment #14) > Created an attachment (id=163273) [details] [review] > Patch for tag_selection_dialog migrated to GtkBuilder From 17a3239c5b0023ff1df9446d2ad901ae25f082dc Mon Sep 17 00:00:00 2001 From: faehnrich <faehnrich@TURING.(none)> Date: Wed, 9 Jun 2010 22:43:54 -0400 Eric, you haven't set up Git correctly! It misses your username and email. Please follow this guide http://live.gnome.org/Git/Developers#Setting_up_Git thanks
Review of attachment 163273 [details] [review]: Heva you tested this? I didn't try but it shouldn't work because you mixed up Glade and GtkBuilder stuff. ::: src/UI.Dialog/TagSelectionDialog.cs @@ +4,1 @@ using Glade; After the transition you can remove this. @@ +8,3 @@ { [Widget] Gtk.ScrolledWindow tag_selection_scrolled; [Widget] Gtk.VBox selection_vbox; Seems like you forgot to change the attributes from (Glade.)Widget to GtkBeans.Builder.Object
Created attachment 163447 [details] [review] Patch for tag_selection_dialog migrated to GtkBuilder
I thought I did that, and it seemed to work. I went through the instructions again.
I think you resubmitted the same patch (which does not apply). Could you commit all your changes and attach those. Also, please run git pull --rebase before submitting your patch. This will make sure no conflicts exist.
Comment on attachment 163273 [details] [review] Patch for tag_selection_dialog migrated to GtkBuilder Oh and mark old patches obsolete once you submit a new version.
Created attachment 164338 [details] [review] Patch for tag_selection_dialog GtkBuilder Transition
Okay, we're getting there, but this patch only seems to contain the changes to convert the attributes. Could you try the following steps: * delete any 000....patch files * git pull --rebase * git format-patch origin/master..master * attach all the generated .patch files.
There doesn't seem to be any generated .patch files.
What output do you get when you run "git format-patch origin/master..". Are you working in a branch? Try this: * git pull * git rebase origin/master * git format-patch origin/master..
for the pull it have: U src/Makefile.am M src/UI.Dialog/TagSelectionDialog.cs U src/f-spot.glade A src/ui/tag_selection_dialog.ui Pull is not possible because you have unmerged files. Please, fix them up in the work tree, and then use 'git add/rm <file>' as appropriate to mark resolution, or use 'git commit -a'. for the rebase: It seems that I cannot create a rebase-apply directory, and I wonder if you are in the middle of patch application or another rebase. If that is not the case, please rm -fr /home/faehnrich/development/f-spot/.git/rebase-apply and run me again. I am stopping in case you still have something valuable there. no output for the format-patch
Looks like you're in the middle of a failed rebase. You'll need to do a "git rebase --abort". Then do "git pull --rebase" It will report a number of conflicts (changes that happened which git cannot merge automatically with your work). You'll have to fix those conflicts, "git add" the conflicted files (once they are fixed) and "git rebase --continue". Only then can you use format-patch.
Created attachment 166866 [details] [review] GtkBuilder transition of tag_selection_dialog
Comment on attachment 166866 [details] [review] GtkBuilder transition of tag_selection_dialog The .ui file you added was saved as a glade file instead of a GtkBuilder file. I've corrected this and will merge it, thanks!