GNOME Bugzilla – Bug 620775
[Overview] Fade dash menus
Last modified: 2010-06-09 15:07:55 UTC
See patch. The constant in Overlay is pretty unfortunate, but - the menus are defined in different places - we probably want to fade the lightbox as well The alternative of having different constants which we assume to be the same is not very appealing either ...
Created attachment 162889 [details] [review] [Overview] Fade dash menus As the design calls for smooth transitions whenever possible, use a similar fade effect for the all-apps and more-docs menus as for the panel menus.
Review of attachment 162889 [details] [review]: Looks good, minor comment that you can just ignore. ::: js/ui/appDisplay.js @@ +195,3 @@ + }); + } else { + this.actor.opacity = 0; I fail to see how this could ever be non 0 here ... but well isn't a big deal anyway. ::: js/ui/dash.js @@ +84,2 @@ this.emit('open-state-changed', this._open); + this.actor.opacity = 0; Same applies here in case you decide to change it and I didn't miss anything. ::: js/ui/overview.js @@ +26,3 @@ +// Time for pane menus to fade in/out +const PANE_FADE_TIME = 0.1; As you said this seems the only sane approach here.
(In reply to comment #2) > I fail to see how this could ever be non 0 here ... but well isn't a big deal > anyway. It is at least once when opening the menu for the first time - the call to actor.hide() in _init() only affects actor.visible, not actor.opacity. Anyway, it looks a little weird without fading the lightbox as well, so push should wait for bug 602466.
(In reply to comment #3) > (In reply to comment #2) > > I fail to see how this could ever be non 0 here ... but well isn't a big deal > > anyway. > > It is at least once when opening the menu for the first time - the call to > actor.hide() in _init() only affects actor.visible, not actor.opacity. Ah OK. > Anyway, it looks a little weird without fading the lightbox as well, so push > should wait for bug 602466. Yeah that makes sense.
Attachment 162889 [details] pushed as 88be8e8 - [Overview] Fade dash menus