After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620476 - accounts_dialog_update_status_infobar mixes const and allocated strings for message
accounts_dialog_update_status_infobar mixes const and allocated strings for m...
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-06-03 13:11 UTC by Rob Bradford
Modified: 2010-06-03 14:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix (5.86 KB, patch)
2010-06-03 13:27 UTC, Rob Bradford 		accepted-commit_now Details | Review

Description Rob Bradford 2010-06-03 13:11:09 UTC 
The variable "message" defined as a const gchar * is often assigned a newly allocated string in this function. This results in those strings being leaked.

I will prepare a patch to resolve this.
Comment 1 Rob Bradford 2010-06-03 13:27:19 UTC 
Created attachment 162649 [details] [review]
Patch to fix
Comment 2 Guillaume Desmottes 2010-06-03 13:51:42 UTC 
Review of attachment 162649 [details] [review]:

++ for both branches. Thanks!
Comment 3 Rob Bradford 2010-06-03 14:00:03 UTC 
Merged to both thanks!