After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620466 - Build with sealed GDK
Build with sealed GDK
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2010-06-03 11:41 UTC by Florian Müllner
Modified: 2010-06-03 22:32 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

Attachments
Use accessors for newly sealed GdkDragContext members (2.33 KB, patch)
2010-06-03 11:41 UTC, Florian Müllner 		committed Details | Review
Add compatibility with GTK+ 2.20 (2.96 KB, patch)
2010-06-03 11:41 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2010-06-03 11:41:09 UTC 
The upcoming versions of GDK will be sealed - first patch replaces direct struct access with accessor functions and bumps the required version to (yet unreleased) 2.22. Second patch adds a small compatibility layer and reverts the required version back to 2.20. The idea behind the split is to revert the second patch once the version is ready to be bumped - it's what we did in mutter/gnome-sheell.
Comment 1 Florian Müllner 2010-06-03 11:41:13 UTC 
Created attachment 162638 [details] [review]
Use accessors for newly sealed GdkDragContext members

This bumps the required GTK+ version to 2.22
Comment 2 Florian Müllner 2010-06-03 11:41:26 UTC 
Created attachment 162639 [details] [review]
Add compatibility with GTK+ 2.20

The upcoming Gdk 2.22/3.0 will be sealed. Accessor functions are
available, but it raises the required minimum version to 2.22 - add
some basic compatibility code, so that it is still possible to build
with an unsealed GDK.
Comment 3 Matthew Barnes 2010-06-03 22:32:25 UTC 
Thanks for this!  Both patches committed to master.

Second one is here:
http://git.gnome.org/browse/evolution-data-server/commit/?id=4a6d9fbbc5d70056435d8795f01b55c447e616c2