After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620277 - [pulsesink] custom clock is still used after NULL state change
[pulsesink] custom clock is still used after NULL state change
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal critical
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-01 16:51 UTC by René Stadler
Modified: 2010-06-02 08:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Very simple test script (258 bytes, text/x-python)
2010-06-01 16:51 UTC, René Stadler 		Details

Description René Stadler 2010-06-01 16:51:15 UTC 
Created attachment 162473 [details]
Very simple test script

This commit introduced a major regression:

http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=e69ba0f94f475975cfa33d651a56fc1567c0238b

If you apply it, reusing pulsesink is mostly broken. As in the simple test script attached, a pipeline like audiotestsrc ! pulsesink will produce broken audio output after a NULL->PLAYING->NULL->PLAYING transition. This also affects playbin2.

The problem is that there is nothing producing a clock-lost message. This leads the gstbin class to keeping the old clock around. Not sure if the fix is as simple as firing clock-lost in pulsesink READY->NULL though.
Comment 1 Sebastian Dröge (slomo) 2010-06-02 08:53:38 UTC 
commit f5057a9fae0caf6f2a65af27ce73fd80338cb48d
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Wed Jun 2 10:52:56 2010 +0200

    pulsesink: Post provide-clock message on the bus if the clock appears/disapp
    
    Fixes bug #620277.