After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620015 - Build only shared libraries by default
Build only shared libraries by default
Status: RESOLVED FIXED
Product: gnote
Classification: Applications
Component: build
git master
Other Linux
: Normal normal
: ---
Assigned To: gnote-maint
gnote-maint
Depends on:
Blocks:
 
 
Reported: 2010-05-29 11:04 UTC by Aurimas Černius
Modified: 2011-05-15 19:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed fix. (625 bytes, patch)
2010-05-29 11:04 UTC, Aurimas Černius
none Details | Review

Description Aurimas Černius 2010-05-29 11:04:34 UTC
Created attachment 162263 [details] [review]
Proposed fix.

There is no reason to build static libraries, so they shouldn't be built by default.

This patch also removes the deprecated symbol AC_PROG_LIBTOOL.
Comment 1 Hubert Figuiere (:hub) 2010-10-28 06:26:28 UTC
Just make sure it does not break on earlier autotools.

Otherwise looks fine to me.
Comment 2 Aurimas Černius 2010-10-28 19:29:57 UTC
Looks like AC_PROG_LIBTOOL is macro, used with libtool 1.5, while LT_INIT is available since 2.2.
Is it OK to require libtool >= 2.2?
Comment 3 Yaakov Selkowitz 2011-05-02 03:26:23 UTC
Another option which keeps compatibility with libtool 1.5 is to add AC_DISABLE_STATIC *before* AC_PROG_LIBTOOL.
Comment 4 Aurimas Černius 2011-05-02 19:51:04 UTC
(In reply to comment #3)
> Another option which keeps compatibility with libtool 1.5 is to add
> AC_DISABLE_STATIC *before* AC_PROG_LIBTOOL.

Yes, however, since I plan Gnote 0.8 to be GTK 3 app, I'll probably use this patch and will require libtool 2.2.
It looks to be widely available and rather reasonable.

This is not yet a final decision.
Comment 5 Aurimas Černius 2011-05-15 19:26:21 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release.