After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619933 - F-spot thread segfaults while trying to get orientation of a JPEG file.
F-spot thread segfaults while trying to get orientation of a JPEG file.
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Browsing
GIT
Other Linux
: Normal critical
: 0.7.1
Assigned To: F-spot maintainers
F-spot maintainers
Depends on: f-spot-taglib
Blocks:
 
 
Reported: 2010-05-28 12:39 UTC by Johan Zaxmy
Modified: 2010-06-19 18:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Picture that triggers f-spot bug (27.87 KB, image/jpeg)
2010-05-28 12:39 UTC, Johan Zaxmy 		  Details
mdb session with the bug triggered (6.69 KB, application/octet-stream)
2010-05-28 12:41 UTC, Johan Zaxmy 		  Details
Fix (710 bytes, patch)
2010-06-03 20:46 UTC, Johan Zaxmy 		needs-work Details | Review

Description Johan Zaxmy 2010-05-28 12:39:25 UTC 
Created attachment 162212 [details]
Picture that triggers f-spot bug

Not sure what exactly happens, it segfault while it tries to check the orientation of the file. See included mdb session. File that triggers the bug included.
Comment 1 Johan Zaxmy 2010-05-28 12:41:03 UTC 
Created attachment 162213 [details]
mdb session with the bug triggered
Comment 2 Ruben Vermeersch 2010-05-30 10:07:12 UTC 
Crash triggering pictures are always very interesting :-). This needs to be in the Taglib# regression suite.
Comment 3 Johan Zaxmy 2010-06-03 20:46:12 UTC 
Created attachment 162691 [details] [review]
Fix
Comment 4 Ruben Vermeersch 2010-06-07 13:20:46 UTC 
Hi Johan!

This looks like a normal "git diff".

Could you:

 * git commit all your changes
 * then do: git pull --rebase
 * (if needed fix any conflicts, git add the conflicting files and git rebase
--continue) (not expecting any)
 * git format-patch

And attach the resulting patch?

That way the patch will have a good commit message + authorship information.

Thanks for looking into this!
Comment 5 Ruben Vermeersch 2010-06-19 18:10:36 UTC 
Just tested this with Taglib#, where it works without a problem. Please re-open if this still happens after we switch to Taglib# (there's a taglib-metadata branch in git if you wish to test this).