GNOME Bugzilla – Bug 619739
Teletext decoder element based on libzvbi
Last modified: 2011-05-23 13:34:12 UTC
Created attachment 162034 [details] [review] New teletext decoder component This patch against gst-plugins-bad adds a new plugin for teletetext decoding. This element is a rework of Sebastien's teletext decoder component (http://github.com/sebp/gst-teletext and http://github.com/ylatuya/gst-teletext). The sink pad accepts the following formats: * "video/mpeg,mpegversion=2,systemstream=true" * "private/teletext" The source pad can push in the following format: * "video/x-raw-rgb" * "text/plain" * "text/html" There is also a subtitles mode which strip off the first and the last line (teletext info lines) and the blank lines if the source pad has negociated "text/plain", and can be used to feed the subtitles into the muxer. This mode could also be used to add transparency to a page to overlay the subtitles. I would also like to add a support for pango markup, but it's currently a work in progress.
Created attachment 163281 [details] [review] 0001-teletextdec-don-t-try-to-push-an-event-on-a-pad-that.patch
Created attachment 163282 [details] [review] 0002-teletextdec-fix-deadlock-on-a-stream-error.patch
How is this related to bug #618850?
It's a different implementation. This plugin is based on Sebastien's teletext decoder and it's based on libzvbi, which takes care of most of the decoding stuff. This element supports as input both mpeg-ts and sliced vbi data, while the other plugin only supports sliced vbi. As output, this one supports RGB, plain text and html and I'll also add support for pango markup, whilst the other element only supports pango markup.
The other element supports txt and pango markup ;-) ; but once you have pango markup; your element is more complete and more feature rich.
Anyway, the support for pango is very basic and mostly oriented to display subtitles with colors, which can't be done using plain/text. What I do is to scan each line and pick the line color from the first non null character. Does it sounds good to you? I can't work on it this weekend, but I'll try to upload a patch on monday/tuesday.
Cool. I'll test it and see if I can use it as a drop in replacement after matching the params.
Created attachment 170123 [details] [review] teletextedec: New teletext decoder plugin based in zvbi
Created attachment 170124 [details] [review] teletextdec: don't try to push an event on a pad that returned an error
Created attachment 170125 [details] [review] teletextdec: fix deadlock on a stream error
Created attachment 170126 [details] [review] teletextdec: add some data in the preroll buffer
Created attachment 170127 [details] [review] teletextdec: add a new method to convert a page in a list of strings
Created attachment 170128 [details] [review] teletextdec: Add support for pango
Can anyone review it or commit the patches in *bad?
Haven't tested it recently; did so a couple months ago. I'll see if I can update the version and re-test it on dvb-s. A couple months ago; it certainly was working properly on ZDF, Arte, RAI, ...
*** Bug 599884 has been marked as a duplicate of this bug. ***
*** Bug 618850 has been marked as a duplicate of this bug. ***
commit 67f23a8539811144db66bac3076749e6d4b4ca54 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Mon May 23 15:32:09 2011 +0200 teletextdec: Minor cleanup and indention fixes commit 827e2d13c1ab8eae451f55a0ce0da2a6565cef3f Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Mon May 23 15:20:45 2011 +0200 teletextdec: Don't use GST_FLOW_IS_FATAL() commit 81134554dbbb4493631b571e2364d78ebb8598da Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Mon May 23 15:14:04 2011 +0200 teletextdec: Fix buffer data leak commit d20de1087cf8dfbfc8e00d04df8db53d312a6dc7 Author: Andoni Morales Alastruey <amorales@flumotion.com> Date: Fri Sep 10 14:34:42 2010 +0200 teletextdec: Add support for pango https://bugzilla.gnome.org/show_bug.cgi?id=619739 commit f4e4fc44f7a3b5e3abf81eca3b7aa3e9a499ca73 Author: Andoni Morales Alastruey <amorales@flumotion.com> Date: Thu Jun 10 12:44:27 2010 +0200 teletextdec: add a new method to convert a page in a list of strings https://bugzilla.gnome.org/show_bug.cgi?id=619739 commit fb98c55f67d77499aa6f0dd5749206e267aac05f Author: Andoni Morales Alastruey <amorales@flumotion.com> Date: Thu Sep 9 16:41:32 2010 +0200 teletextdec: add some data in the preroll buffer https://bugzilla.gnome.org/show_bug.cgi?id=619739 commit 126a98d967275b5f4ed0c09e5ff9c8e75bafd09f Author: Andoni Morales Alastruey <amorales@flumotion.com> Date: Thu Jun 10 13:55:30 2010 +0200 teletextdec: fix deadlock on a stream error https://bugzilla.gnome.org/show_bug.cgi?id=619739 commit afd240c621e77a87fe09a5b4559451fc7ddbd88a Author: Andoni Morales Alastruey <amorales@flumotion.com> Date: Thu Jun 10 12:42:42 2010 +0200 teletextdec: don't try to push an event on a pad that returned an error https://bugzilla.gnome.org/show_bug.cgi?id=619739 commit 8bb6ff414f320b84a04abeaff25c5d261d087ace Author: Andoni Morales Alastruey <amorales@flumotion.com> Date: Mon Sep 13 11:59:18 2010 +0200 teletextdec: New teletext decoder plugin based in zvbi https://bugzilla.gnome.org/show_bug.cgi?id=619739