After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619649 - Remove deprecated code from GdkColor
Remove deprecated code from GdkColor
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
2.90.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 597742
 
 
Reported: 2010-05-25 18:41 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-09-27 00:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove deprecated code from GdkColor (24.98 KB, patch)
2010-05-25 18:45 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Remove unneeded code from GdkColor x11 and win32 implementations (9.20 KB, patch)
2010-06-06 22:45 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review

Description Javier Jardón (IRC: jjardon) 2010-05-25 18:41:55 UTC 
Patch attached
Comment 1 Javier Jardón (IRC: jjardon) 2010-05-25 18:45:08 UTC 
Created attachment 161966 [details] [review]
Remove deprecated code from GdkColor

I wonder if makes sense the "writeable" parameter on gdk_colormap_alloc_color(), now that gdk_color_change() is removed
Comment 2 Christian Dywan 2010-05-27 16:43:42 UTC 
Review of attachment 161966 [details] [review]:

Looks good to me.

Is there any way anymore to modify a colour? Then maybe the code paths for that could be removed and gdk_colormap_alloc_color could simply state "writeable: this value is ignored".
Comment 3 Matthias Clasen 2010-06-06 21:30:54 UTC 
Looks good to me as well. And stating that writeable is ignored would be good
Comment 4 Javier Jardón (IRC: jjardon) 2010-06-06 22:36:26 UTC 
Comment on attachment 161966 [details] [review]
Remove deprecated code from GdkColor

committed with the documentation notes.

commit 2ace397eb52df6627bbcd8caef40a7dab82618f8
Comment 5 Javier Jardón (IRC: jjardon) 2010-06-06 22:45:25 UTC 
Created attachment 162896 [details] [review]
Remove unneeded code from GdkColor x11 and win32 implementations

If we assume that gdk_colormap_alloc_colors() writable parameter is always FALSE we can remove all this unneeded code
Comment 6 Javier Jardón (IRC: jjardon) 2010-09-27 00:35:57 UTC 
GdkColormap was removed in GTK+3, so we can close this bug now.