After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619580 - Do not fail if json Python module is not available
Do not fail if json Python module is not available
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-05-25 08:27 UTC by Frederic Peters
Modified: 2010-05-25 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not fail if json Python module is not available (1.26 KB, patch)
2010-05-25 08:28 UTC, Frederic Peters 		reviewed Details | Review

Description Frederic Peters 2010-05-25 08:27:47 UTC 
023a274e introduced a dependency on the Python json module, which is new in Python 2.6.
Comment 1 Frederic Peters 2010-05-25 08:28:41 UTC 
Created attachment 161916 [details] [review]
Do not fail if json Python module is not available

Fallback to old simplejson module if present, and options that require
the json module (create extension and performance) if absent.
Comment 2 Owen Taylor 2010-05-25 14:22:38 UTC 
Review of attachment 161916 [details] [review]:

Could you change it to 

 "The Python simplejson module is required to create a new GNOME Shell extension"
             ^^^^^^

and same for the other case, since if you don't have json, you need simplejson, not json. Otherwise looks fine to commit
Comment 3 Frederic Peters 2010-05-25 14:34:02 UTC 
Pushed (f1e310412).