GNOME Bugzilla – Bug 619312
[PATCH] build: fix --without-gtk build for windows
Last modified: 2010-05-28 15:04:44 UTC
Created attachment 161667 [details] [review] patch Folks, the attached patch fixes the --without-gtk build when I'm cross compiling using Fedora 13's mingw packages. The configure options that I used when compiling were '--without-gtk --without-gconf'. Doesn't break the build for me on Debian sid w/ gcc 4.4 either. I didn't fill out the ChangeLog or NEWS either, as git-am doesn't like applying patches when others have updated those files in the meantime. If the patch seems appropriate, I can write those short pieces. yours, Bobby
--without-gconf is not relevant here since win32 builds do not use gconf. I'll test that when I have time, hopefully next week.
Actually, the only win32 related change is the goffice.def definition, all other things seems related to LDFLAGS="-Wl,--no-undefined" or equivalent. One minor thing: gog_klass->populate_editor = NULL; is not needed (NULL is the default value). I'll commit the patch with this little change.
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
(In reply to comment #2) > Actually, the only win32 related change is the goffice.def definition, all > other things seems related to LDFLAGS="-Wl,--no-undefined" or equivalent. > > One minor thing: gog_klass->populate_editor = NULL; is not needed (NULL is the > default value). > > I'll commit the patch with this little change. ah, that makes sense. I didn't think to check how the class was initialized.
thanks!