After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619187 - Tiff Writing
Tiff Writing
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
GIT
Other All
: Normal normal
: 0.7.1
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks: 618683
 
 
Reported: 2010-05-20 11:33 UTC by Mike Gemünde
Modified: 2010-06-14 14:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
First implementation of tiff-writing (1.66 KB, patch)
2010-05-20 11:33 UTC, Mike Gemünde 		rejected Details | Review
Extend GenerateTestFixture (1.42 KB, patch)
2010-05-20 11:33 UTC, Mike Gemünde 		rejected Details | Review
Add a bunch of new tests for tiff and jpeg (1002 bytes, patch)
2010-05-20 11:33 UTC, Mike Gemünde 		rejected Details | Review
regenerate basic tiff test with generation tool (1006 bytes, patch)
2010-05-20 11:33 UTC, Mike Gemünde 		rejected Details | Review

Description Mike Gemünde 2010-05-20 11:33:41 UTC 
Implement tiff writing for taglib-sharp.
Comment 1 Mike Gemünde 2010-05-20 11:33:43 UTC 
Created attachment 161539 [details] [review]
First implementation of tiff-writing
Comment 2 Mike Gemünde 2010-05-20 11:33:46 UTC 
Created attachment 161540 [details] [review]
Extend GenerateTestFixture
Comment 3 Mike Gemünde 2010-05-20 11:33:50 UTC 
Created attachment 161541 [details] [review]
Add a bunch of new tests for tiff and jpeg
Comment 4 Mike Gemünde 2010-05-20 11:33:53 UTC 
Created attachment 161542 [details] [review]
regenerate basic tiff test with generation tool
Comment 5 Ruben Vermeersch 2010-05-20 12:05:10 UTC 
Review of attachment 161539 [details] [review]:

::: src/TagLib/IFD/Entries/StripOffsetsIFDEntry.cs
@@ -52,2 +66,2 @@
 		/// <summary>
-		///    Constructor.
+		///    Construcor.

Fix your accent! ;-)
Comment 6 Ruben Vermeersch 2010-05-20 12:07:39 UTC 
Review of attachment 161539 [details] [review]:

::: src/TagLib/IFD/Entries/StripOffsetsIFDEntry.cs
@@ -31,1 +31,6 @@
-	///    Contains the offsets to the image data strips.
+	///    Contains the data of a Thumbnail. Since the thumbnail is
+	///    referenced by two long entries (offset to the data and length)
+	///    we need to take care of this special case.
... 3 more ...

Sure this is a correct change and not a reverse patch? It's a bit strange to replace a strip offsets comment by a thumbnail comment in StripOffsetsIFDEntry.
Comment 7 Mike Gemünde 2010-05-20 12:21:13 UTC 
stil merged
Comment 8 Ruben Vermeersch 2010-05-20 12:23:36 UTC 
Comment on attachment 161539 [details] [review]
First implementation of tiff-writing

Rejecting all patches because Mike was apparently drunk or sleepy while submitting them ;-)