After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619086 - Hash tables need annotation of element types
Hash tables need annotation of element types
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: API
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2010-05-19 14:08 UTC by Gustavo Noronha (kov)
Modified: 2010-05-24 23:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Annotate hash tables element types (6.08 KB, patch)
2010-05-19 14:08 UTC, Gustavo Noronha (kov) 		reviewed Details | Review

Description Gustavo Noronha (kov) 2010-05-19 14:08:28 UTC 
Created attachment 161443 [details] [review]
Annotate hash tables element types

I was playing with using soup in seed and noticed many hash tables do not have their elements types annotated. The attached patch should hopefully be all that is needed.
Comment 1 Dan Winship 2010-05-19 15:09:26 UTC 
Comment on attachment 161443 [details] [review]
Annotate hash tables element types

>+++ b/libsoup/soup-value-utils.c
>@@ -56,7 +56,7 @@ soup_value_hash_value_free (gpointer val)
>  * Creates a #GHashTable whose keys are strings and whose values
>  * are #GValue.
>  *
>- * Return value: a new empty #GHashTable
>+ * Return value: (element-type utf8 GType): a new empty #GHashTable

All the soup_value_hash hashtables should be (element-type utf8 GValue), not GType.

otherwise good to commit

(modulo the caveat that already applies to lots of utf8 annotations in libsoup, which is that the strings aren't actually guaranteed to be utf8, and I need to do something about that...)
Comment 2 Dan Winship 2010-05-24 23:52:53 UTC 
pushed with above fix