Created attachment 161435 [details] [review]
[StThemeNode] Make shadows respect paint opacity

Currently shadows disregard the overall opacity, so e.g. setting
an ancestor's opacity does not effect the shadow. Fix this by
deferring the setting of the shadow's color until it is painted.
Also move duplicated drawing code from st_theme_node_paint() into
its own function.

Review of attachment 161435 [details] [review]:

Looks good to me, couple of tiny quibbles - good to commit with those fixed. (How did we get such a huge block of duplicated code in the first place? :-)

::: src/st/st-theme-node-drawing.c
@@ +202,3 @@
 
+  /* We set up the material to blend the shadow texture with the combine
+   * constant, but defer setting the latter until painting to take the

Minor English style quibble

 "until painting, so that we can take..."

@@ +855,2 @@
 static void
+paint_shadow_with_opacity (CoglHandle       shadow,

Especially since CoglHandle is a generic type, the name of the object should convey something about its actual type - so shadow_material, not shadow

Attachment 161435 [details] pushed as a433a1c - [StThemeNode] Make shadows respect paint opacity