GNOME Bugzilla – Bug 618929
Plugin "totemCone" has some uninplemeted methods and properties from VLC JavaScript API (patches applied)
Last modified: 2010-05-18 15:12:39 UTC
This plugin is missing some methods and properties from VLC JavaScript API: - playlist.togglePause() - input.time The input.time property affects seeking too (for example: input.time += 1000 ; input.time -= 1000 ; input.time = 1000;). Also the part of the code that checks for the visibility of the controls is not quite right. VLC uses a toolbar argument, but it is not documented.
Created attachment 161271 [details] [review] Get/set the time
Created attachment 161272 [details] [review] Implementation of togglePause()
Created attachment 161273 [details] [review] Add support for VLC "toolbar" argument: with or without "vlc" mimetype.
Very nice. Would it be possible for you to provide all 3 patches in git-formatted form, so as not to lose authoring information, and document the toolbar argument (at least with a short reference to the portion of code implementing this in VLC).
Created attachment 161356 [details] [review] Get/set input.time property in git-formated form
Created attachment 161357 [details] [review] Implementation ot togglePause() in git-formated form
Created attachment 161358 [details] [review] VLC "toolbar" argument support in git-formated form
(In reply to comment #4) > Would it be possible for you to provide all 3 patches in > git-formatted form, >and document the > toolbar argument (at least with a short reference to the portion of code > implementing this in VLC). Done. Is this OK?
Fixed the last commit message and the indentation of the comment.