After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618827 - The generatorCache is not getting dumped when using Gecko's caret or structural navigation due to lack of AT-SPI events
The generatorCache is not getting dumped when using Gecko's caret or structur...
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.31.x
Other All
: Normal normal
: 2.32.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403 404409
 
 
Reported: 2010-05-17 00:47 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2010-09-20 10:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix (875 bytes, patch)
2010-05-17 02:16 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2010-05-17 00:47:06 UTC
Steps to reproduce:

1. In a message received in Thunderbird or a web page in Firefox, move to one line within a paragraph and perform a where Am I.

2. Move to another line in that same paragraph and repeat the where Am I.

Expected results: The line at the caret would be read each time

Actual results: In step 2, the line from step 1 is read.

This doesn't seem to occur when the object is different; only when it's a different line in the same text object.
Comment 1 Joanmarie Diggs (IRC: joanie) 2010-05-17 01:57:54 UTC
Aha. Turns out this only happens when Gecko is controlling the caret. When Gecko is controlling the caret and we're in the same object, we don't get any events (caret-moved, focus, etc.). The thing that clears out the generatorCache is script.py's processObjectEvent. No AT-SPI events means we don't clear out the cache. I should have a fix for this issue shortly.
Comment 2 Joanmarie Diggs (IRC: joanie) 2010-05-17 02:16:16 UTC
Created attachment 161198 [details] [review]
Fix

One line, very safe fix: Clear self.generatorCache in the Gecko script's consumesKeyboardEvent().

Committed to both the gnome-2-30 branch and master.
Comment 3 Joanmarie Diggs (IRC: joanie) 2010-05-17 02:17:38 UTC
FWIW in comment 1: I mean when Orca is controlling the caret in the Gecko script. Anyhoo, the fix is right. :-)