After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618632 - PATCH: Collaboration diagramm exceeds the page border in LaTeX generated pdf files
PATCH: Collaboration diagramm exceeds the page border in LaTeX generated pdf ...
Status: RESOLVED FIXED
Product: doxygen
Classification: Other
Component: general
1.6.3-SVN
Other Linux
: Normal normal
: ---
Assigned To: Dimitri van Heesch
Dimitri van Heesch
Depends on:
Blocks:
 
 
Reported: 2010-05-14 14:26 UTC by Jan Schmidt
Modified: 2010-06-15 11:22 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jan Schmidt 2010-05-14 14:26:57 UTC
Overview:
---------
Collaboration diagramms which have both a width larger than maxWidth AND an  
height larger than maxHeight exceed the page border if width/maxWidth is less than height/maxHeight.

Patch:
------

in src/dot.cpp:2020
in function QCString DotClassGraph::writeGraph(...)

instead of:

      if (width>maxWidth)
      {
        out << "\\includegraphics[width=" << maxWidth << "pt]";
      }
      else if (height>maxHeight)
      {
        out << "\\includegraphics[height=" << maxHeight << "pt]";
      }
      else
      {
        out << "\\includegraphics[width=" << width << "pt]";
      }

write this:

      if ( (width>maxWidth) || (height>maxHeight) )
      {
	if ( (float)width/(float)maxWidth > (float)height/(float)maxHeight )
	{
	  out << "\\includegraphics[width=" << maxWidth << "pt]";
	}
	else
	{
	  out << "\\includegraphics[height=" << maxHeight << "pt]";
	}
      }
      else
      {
	out << "\\includegraphics[width=" << width << "pt]";
      }
Comment 1 Dimitri van Heesch 2010-05-16 10:01:48 UTC
Thanks for the patch.
I'm currently reworking dot.cpp, and I'll include your patch while I'm at it.
Comment 2 Dimitri van Heesch 2010-06-15 11:22:25 UTC
This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.7.0. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information
that you think can be relevant.