After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618546 - Incorrect Vala configure check
Incorrect Vala configure check
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
2.30.x
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-05-13 15:22 UTC by Simon Wenner
Modified: 2010-06-30 18:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.16 KB, patch)
2010-05-13 15:22 UTC, Simon Wenner 		none Details | Review
updated vala configure check patch (1.94 KB, patch)
2010-05-14 16:21 UTC, Simon Wenner 		committed Details | Review

Description Simon Wenner 2010-05-13 15:22:45 UTC 
Created attachment 160974 [details] [review]
proposed patch

Totem's Vala configure check is incorrect. libvala is a library for applications that process vala source code. Totem does not depend on it. The only dependency of a vala plugin is the vala compiler (valac).
Comment 1 Bastien Nocera 2010-05-13 17:25:44 UTC 
And AM_PROG_VALAC() is defined in an m4 in gnome-common? Or as shipped in vala itself? If so, from which version was that added? (because it's not in my pretty old version).
Comment 2 Simon Wenner 2010-05-13 18:02:58 UTC 
It's part of Automake (Version 1.11):
http://www.gnu.org/software/hello/manual/automake/Vala-Support.html
Comment 3 Bastien Nocera 2010-05-14 10:42:18 UTC 
(In reply to comment #2)
> It's part of Automake (Version 1.11):
> http://www.gnu.org/software/hello/manual/automake/Vala-Support.html

Then you'll need to up the dependencies for automake in the configure.in and in the autogen.sh as well.
Comment 4 Simon Wenner 2010-05-14 16:21:59 UTC 
Created attachment 161076 [details] [review]
updated vala configure check patch

Done.
Comment 5 Bastien Nocera 2010-05-14 16:25:59 UTC 
Comment on attachment 161076 [details] [review]
updated vala configure check patch

Please commit to master
Comment 6 Tim-Philipp Müller 2010-06-30 18:14:48 UTC 
IIRC the problem with AM_PROG_VALA is that if you specify a minimum vala version and vala is installed, but not recent enough, then the macro just AC_MSG_ERROR()s out, and you can't do anything about it, or just disable vala support.