After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618510 - slave crash with unstable version if XFree86_VT property not set for Xserver
slave crash with unstable version if XFree86_VT property not set for Xserver
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.31.x
Other All
: Normal critical
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on: 609272
Blocks:
 
 
Reported: 2010-05-13 06:40 UTC by Halton Huo
Modified: 2010-05-14 02:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Check envrioment WINDOWPATH before setting it. (1.17 KB, patch)
2010-05-13 07:01 UTC, Halton Huo 		committed Details | Review

Description Halton Huo 2010-05-13 06:40:19 UTC 
With fixing for bug #609272, WINDOWPATH is set correctly for Xorg, but not for other Xserver like Xvnc and Xnewt.

On unstable gdm, the G_DEBUG is set to fatal_criticals automatically, which leads gdm-simple-slave crash with following statck.

$pstack core.gdm-simple-slave.19687
core 'core.gdm-simple-slave.19687' of 19687:    /usr/lib/gdm-simple-slave --display-id /org/gnome/DisplayManager/Displ
-----------------  lwp# 1 / thread# 1  --------------------
 fe9607c7 _lwp_kill (1, 5, 80476e4, fe908ffe) + 7
 fe90900a raise    (5, a, 80cc3b8, 0) + 22
 feab1927 g_logv   (0, 8, 80870f0, 8047ba8) + 453
 feab1a3d g_log    (0, 8, 80870f0, 8087174, 862, 8088f64) + 25
 0807072d gdm_session_direct_set_environment_variable (80c4000, 8088fcc, 0) + cd
 080708af setup_session_environment (80c4000, 0) + 13f
 08070ab1 gdm_session_direct_start_session (80c4000, 0) + 111
 0806b74a gdm_session_start_session (80c4000, 0) + 6a
 080784cf start_session_timeout (80b0800, feb62074, 8047c60, feaabf10) + 12f
 feaabf26 g_idle_dispatch (80cae08, 80783a0, 80b0800, 8047cb8) + 22
 feaa98ee g_main_context_dispatch (80a7550, c8, 80c5d70, 7) + 262
 feaa9f99 g_main_context_iterate (80a7550, 1, 1, 80a04a0) + 47d
 feaaa5c5 g_main_loop_run (80af860, 0) + 1dd
 08060d0b main     (1, 8047dc8, 8047dd8, 8047dbc) + 2fb
 0806041d _start   (3, 8047e78, 0, 0, 0, 8047ec2) + 7d
-----------------  lwp# 2 / thread# 2  --------------------
 fe9605b7 __read   (9, fe7aef50, 14, feaabaa2) + 7
 feaababd child_watch_helper_thread (0, 80b1b60, 200, fead2252) + 29
 fead2377 g_thread_create_proxy (80b1b60, fe9ee000, fe7aefe8, fe95bc0e) + 133
 fe95bc63 _thrp_setup (fe6a0200) + 9b
 fe95bef0 _lwp_start (fe6a0200, 0, 0, 0, 0, 0)
Comment 1 Halton Huo 2010-05-13 07:01:16 UTC 
Created attachment 160952 [details] [review]
Check envrioment WINDOWPATH before setting it.

Please review this patch.
Comment 2 Ray Strode [halfline] 2010-05-13 12:24:29 UTC 
Comment on attachment 160952 [details] [review]
Check envrioment WINDOWPATH before setting it.

Looks good.
Comment 3 Halton Huo 2010-05-14 02:43:42 UTC 
Committed as 1d2ece98b97adff869af3eaf65d44202ed7a7af9