GNOME Bugzilla – Bug 618351
avimux crashes when fed from filesrc
Last modified: 2010-05-11 12:00:02 UTC
Running the following pipeline gst-launch filesrc location=/bin/bash ! avimux ! fakesink causes a SIGFPE in avimux. While this pipeline is wrong and should not work, it should not crash either. In particular, it's a common pipeline for newcomers to encounter when they start experimenting with GStreamer. Not sure what the right fix is (check that all pads are negotiated probably?), so I'm filing this.
Also, https://bugzilla.redhat.com/show_bug.cgi?id=590699 is the upstream bug report.
Yes, you should check in the collected function, that all pads are properly negotiated. And probably add some checks in the setcaps functions too.
Created attachment 160807 [details] [review] Check that pads have been negotiated
I guess this should go in before gst-plugins-good freezes for the next release.
commit 5ae7119d11ba959c23cdaf57ebf61aeb06b77253 Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk> Date: Tue May 11 12:06:10 2010 +0200 avimux: check that pads have been negotiated Also set fcc_handler field in audio stream header. Fixes #618351.