GNOME Bugzilla – Bug 618248
Network map source shouldn't parent an actor on the stage
Last modified: 2010-05-23 17:35:10 UTC
This leads to a nasty visual bug where we're using it. Attached is a patch that improves the way the error tile works so that it doesn't need an actor to clone and instead every instance shares the same texture handle directly.
Created attachment 160707 [details] [review] Patch to fix
Created attachment 160708 [details] [review] Better patch Neil pointed out that clutter_actor_destroy just does an unparent. We don't parent the actor so instead we should sink the floating reference and then drop it.
Hi Rob, thanks for looking at it. Could you please make your patch on top of the current mainline HEAD? Your patch seems to be against a very old 0.5.x version and there have been many changes meanwhile. You want to look at champlain-error-tile-source.c. When I implemented the new tile-loading architecture I just copied the code (without liking it much) and thought about making something nicer later on. I've fixed the visual bug by hiding the error actor but this is clearly just a workaround, so thanks for looking into the correct solution.
Well I did it for libchamplain-0.4 since that's the latest stable branch and that's what we're shipping. I'll rebase that patch for master though.
Created attachment 160899 [details] [review] Patch for master Here is a version for master.
Thanks! I thought that this error tile loading was in 0.5 only that's why I asked for a version for master. I've already applied it to master. There are several issues that should be fixed in the 0.4 branch so after releasing 0.6 (in about one week) I would like to make one more 0.4.x release including your patch.
Applied for 0.4.