GNOME Bugzilla – Bug 617739
[PLUGIN-MOVE] Move capssetter to gst-plugins-good
Last modified: 2010-05-11 13:35:06 UTC
Subject says it all, should be in good enough shape.
Looks good in general but why don't you use gst_caps_is_fixed() instead of that caps-structure-value iteration thing?
I am assuming you mean why not use gst_caps_is_fixed (new_caps). Because that would require new_caps to consist of a single structure, which must be fixed. In this case, it is also fine if new_caps consists of several structures, each of which is fixed. [And we do not seem to have a gst_structure_is_fixed(), which leads to some complication in the loop. Alternative might be gst_caps_copy_nth() etc, but that would then involve yet another copy ...]
(In reply to comment #2) > that would then involve yet another copy ... Premature optimization, root of all evil, etc. I much prefer clearer code where it's obvious whatit does to something that optimizaes performance when performance isn't even important. </rant>
commit ee063478ffc98b1e2c122f0bfb8088da4fa51e70 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Tue May 11 13:08:41 2010 +0100 Remove capssetter element It has been moved to gst-plugins-good. See #617739. commit 61811ff11346622c409b7251815ad6fa0f9b2588 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Tue May 11 13:07:19 2010 +0100 Move capsfilter element from -bad to -good Hook up moved files to the build infrastructure and docs. Fixes #617739.