GNOME Bugzilla – Bug 617666
Doesn't switch off startup-notification
Last modified: 2017-08-16 14:40:23 UTC
1. In GDM, turn on Orca in the a11y preferences 2. Switch orca off 3. Switch it on again, and notice that the waiting cursor carries on spinning for a while Orca should be finishing the startup notification with gdk_notify_startup_complete().
(3.0 Planning Spam-o-rama. Sorry!)
Still a problem in 3.13. See also bug 735761.
I've never been able to reproduce this. Since bug 735761 didn't remove the .desktop file in order to accommodate/not break expectations of/whatever non-GNOME environments, Orca (commit 198bd5bdea) now calls gdk_notify_startup_complete(). I don't see any difference, but since I wasn't ever able to reproduce this issue.... <insert shrug here> Bastien, is there anything different/else I should be doing to resolve this issue?
I don't remember how it was started on older versions of GNOME, but I'm guessing that it might be through gnome-session, and g_app_info..() which would automatically use startup notification if available. A couple of problems though: - notifications have never worked properly on Wayland (see bug 768531) - gdm now uses Wayland by default - orca doesn't ship a .desktop file that gnome-shell could associate with the application being launched The changes in that commit should be enough, though I simplified them somewhat in the attached patch. Fine to close afterwards.
Created attachment 357725 [details] [review] Remove unneeded try/except around Gdk.notify_startup_complete() Fix up 198bd5bdea3765eedab4299909cc4e2d7dd5e78c as the call is always successful.
Comment on attachment 357725 [details] [review] Remove unneeded try/except around Gdk.notify_startup_complete() Ok, thanks!
Attachment 357725 [details] pushed as c8d223e - Remove unneeded try/except around Gdk.notify_startup_complete()