After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 617322 - Move documentation to inline comments: GtkEntryCompletion
Move documentation to inline comments: GtkEntryCompletion
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 599599
 
 
Reported: 2010-04-30 20:14 UTC by Garrett Regier
Modified: 2011-01-04 22:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Move documentation to inline comments: GtkEntryCompletion (11.60 KB, patch)
2010-04-30 20:14 UTC, Garrett Regier 		needs-work Details | Review

Description Garrett Regier 2010-04-30 20:14:33 UTC 
Created attachment 160011 [details] [review]
Move documentation to inline comments: GtkEntryCompletion

Move documentation to inline comments for GtkEntryCompletion
Comment 1 Javier Jardón (IRC: jjardon) 2010-10-02 23:16:39 UTC 
Review of attachment 160011 [details] [review]:

Some minor comments

::: gtk/gtkentrycompletion.c
@@ +61,3 @@
+ * When the user selects a completion, the content of the entry is updated.
+ * By default, the content of the entry is replaced by the text column of the
+ * model, but this can be overridden by connecting to the ::match-selected signal

Use #GtkEntryCompletion::match-selected here

@@ +71,3 @@
+ * "actions" in the popup window. Their appearance is similar to menuitems,
+ * to differentiate them clearly from completion strings. When an action is
+ * selected, the ::action-activated signal is emitted.

Use #GtkEntryCompletion::action-activated here

@@ +73,3 @@
+ * selected, the ::action-activated signal is emitted.
+ *
+ */

This blank line can be removed