After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 617292 - gnome-icon-theme needs to include scalable in index.theme (for -symbolic)
gnome-icon-theme needs to include scalable in index.theme (for -symbolic)
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: general
2.30.x
Other All
: Normal major
: ---
Assigned To: Jakub Steiner
Jakub Steiner
Depends on:
Blocks:
 
 
Reported: 2010-04-30 15:33 UTC by Jakub Steiner
Modified: 2010-05-24 16:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.78 KB, patch)
2010-05-24 15:27 UTC, Matthias Clasen 		none Details | Review

Description Jakub Steiner 2010-04-30 15:33:39 UTC 
gnome-icon-theme-symbolic doesn't ship its own index.theme as it's an extension to gnome-icon-theme. It does however install its icons into $PREFIX/share/icons/scalable/<context>/ and this size isn't defined in gnome-icon-theme 's index.theme.

the index.theme in gnome-icon-theme is generated at buidl time based on the icons included and thus scalable is left out. We need to special case this. The sections needs to read something along:

[scalable/actions]
Context=Actions
Size=16
Type=Scalable
MinSize=8
Maxsize=512
Comment 1 Matthias Clasen 2010-04-30 18:00:31 UTC 
Yeah, this is correct. In our F13 package, we currently add

[scalable/apps]
Size=48
MinSize=32
MaxSize=256
Context=Applications
Type=Scalable

[scalable/actions]
Size=48
MinSize=32
MaxSize=256
Context=Actions
Type=Scalable

[scalable/devices]
Size=48
MinSize=32
MaxSize=256
Context=Devices
Type=Scalable

[scalable/status]
Size=48
MinSize=32
MaxSize=256
Context=Status
Type=Scalable

but the {Min,Max,}Size fields for the symbolic icons should be as you say.
One thing to point out here is that we still have some modules in GNOME that install icons below gnome/scalable/... which are not symbolic icons, e.g libgweather. Those should probably be transitioned to installing fixed sizes up to 256, so that the scalable tree can be exclusively for symbolic icons.
Comment 2 Jakub Steiner 2010-05-05 00:27:58 UTC 
While we can have symbolic icons install to a new size "symbolic" for example, I don't think apps should be installing to a specific theme at all. App launcher icons go to the hicolor theme and application specific icons go into the app's domain -- http://live.gnome.org/ThemableAppSpecificIcons
Comment 3 Sebastian Dröge (slomo) 2010-05-06 13:24:42 UTC 
Will this be fixed for the next 2.30 release so application can use their scalable SVG icons again and for 2.31/3.0 the applications can be fixed then?
Comment 4 Matthias Clasen 2010-05-06 14:25:08 UTC 
The scalable directories that are getting added back are for the specific purpose of symbolic icons, not for random application icons.

Applications should not install icons in the gnome icon theme, anyway.
Comment 5 Bastien Nocera 2010-05-06 23:25:43 UTC 
(In reply to comment #3)
> Will this be fixed for the next 2.30 release so application can use their
> scalable SVG icons again and for 2.31/3.0 the applications can be fixed then?

It's supposed to be installed in hicolor.
Comment 6 Matthias Clasen 2010-05-24 15:27:34 UTC 
Created attachment 161876 [details] [review]
patch
Comment 7 Lapo Calamandrei 2010-05-24 16:13:42 UTC 
Patch applied, thanks Matthias, closing.