After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616848 - Application and toolkit scripts should not call methods in braille.py
Application and toolkit scripts should not call methods in braille.py
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: braille
2.30.x
Other All
: Normal normal
: 2.32.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 491756
 
 
Reported: 2010-04-26 14:09 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2013-01-02 15:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
part 1 of the fix (52.77 KB, patch)
2010-04-27 03:22 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review
rest of the fix (6.65 KB, patch)
2010-05-01 21:39 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2010-04-26 14:09:42 UTC 
One of the side effects of application and toolkit scripts calling methods in braille.py is that there are approximately a bazillion places in which things can blow up if we only perform braille functions when braille support is enabled (i.e. fixing bug 616847).

We could either add in a bazillion sanity checks, and hope that future callers do the same, or we can centralize calls to methods in braille.py and do a handful of sanity checks.
Comment 1 Joanmarie Diggs (IRC: joanie) 2010-04-27 03:22:26 UTC 
Created attachment 159660 [details] [review]
part 1 of the fix

This creates the bulk of the necessary static methods in default.py and causes many scripts to begin using them. More conversion is still necessary, and I've not yet started on the Gecko script conversion. That work will follow in a few days.

This patch is fully regression tested and pylints to a 10.0.
Comment 2 Joanmarie Diggs (IRC: joanie) 2010-05-01 21:39:48 UTC 
Created attachment 160121 [details] [review]
rest of the fix

This causes the Gecko script to use the new braille methods in default.py. It also corrects a silly mistake in one of the new methods introduced by patch 1.

Fully regression tested and pylinted.