GNOME Bugzilla – Bug 616822
Critical warnings when opening a contact
Last modified: 2010-08-02 10:12:39 UTC
evolution 2.31.1 When i double click on any contact to open it, i see critical warnings on evolution terminal (evolution:29398): e-image-chooser.c-CRITICAL **: image_chooser_set_icon_name: assertion `icon_info != NULL' failed (evolution:29398): Gtk-WARNING **: Unknown property: GtkExpander.shadow-type (evolution:29398): e-image-chooser.c-CRITICAL **: e_image_chooser_set_from_file: assertion `filename != NULL' failed [Thread 0xa70c7b70 (LWP 29464) exited]
I see only that "Unknown property: GtkExpander.shadow-type", could you get a backtrace of those other two, please?
Though those are probably because of missing icons for the "contact" (a person in the left-top corner in the contact editor), which used to be 48x48, but is 16x16 now.
Will valgrind traces help here ? (evolution:11228): e-image-chooser.c-CRITICAL **: image_chooser_set_icon_name: assertion `icon_info != NULL' failed ==11228== Invalid write of size 4 ==11228== at 0x62837B2: ??? (in /usr/lib/gtk-2.0/modules/libgnomebreakpad.so) ==11228== by 0x5818F1A: g_logv (gmessages.c:519) ==11228== by 0x5819296: g_log (gmessages.c:569) ==11228== by 0x4338761: image_chooser_set_property (e-image-chooser.c:339) ==11228== by 0x5788227: g_object_constructor (gobject.c:973) ==11228== by 0xD0B5277: ??? ==11228== Address 0xd913bd0 is 0 bytes after a block of size 64 alloc'd ==11228== at 0x4025FCB: calloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so) ==11228== by 0x5817409: g_malloc0 (gmem.c:152) ==11228== by 0x62837A1: ??? (in /usr/lib/gtk-2.0/modules/libgnomebreakpad.so) ==11228== by 0x5818F1A: g_logv (gmessages.c:519) ==11228== by 0x5819296: g_log (gmessages.c:569) ==11228== by 0x4338761: image_chooser_set_property (e-image-chooser.c:339) ==11228== by 0x5788227: g_object_constructor (gobject.c:973) ==11228== by 0xD0B5277: ??? ==11228==
> by 0xD0B5277: ??? Hmm, I was hoping in this, to know from where it was called to create itself. But, seeing Fridrich's notes on IRC about missing icons [1] [2] (similar for master), I believe it'll help you here too, so you'll have the same output on console as me, (comment #1) Could you try to update and rebuild, please? [1] http://git.gnome.org/browse/evolution/commit/?h=gnome-2-30&id=9c987e31662913efcce3db05e0700d1e647903d3 [2] http://git.gnome.org/browse/evolution/commit/?h=gnome-2-30&id=7bbe63b9dab8a9a7bd023c8d061eaf60bf55df19
I still see these warnings even after upgrading to latest master.
In mapi address book, i am seeing one more warning when opening a contact. (evolution:11065): eab-widgets-CRITICAL **: contact_display_url_requested: assertion `icon_info != NULL' failed
+ Trace 221677
The last trace is looking for im-aim icon. You can reproduce with any contact, just have them stored AIM value for it. Mine icon is in /usr/share/icons/gnome/16x16/apps/im-aim.png provided by gnome-icon-theme-2.28.0-1.fc12.noarch For the contact editor I see: /usr/share/icons/gnome/16x16/stock/generic/stock_person.png though it should be 48x48, as I mentioned in the comment #2 above. Was these dropped from the latest gnome-icon-theme as well?
Created commit 05148d6 in evo master (2.31.2+) for GtkExpander::shadow-type Only icons left here.
Created attachment 166938 [details] [review] Patch to use new icon names commit 728951346b2d7694be3d4b9554667f23944b1451 Author: Rob Bradford <rob@linux.intel.com> Date: Sun Aug 1 19:29:56 2010 +0100 addressbook/gui, plugins/groupwise, widgets/misc: Update to new icon theme Since gnome-icon-theme 2.30.x the icon name for the default avatar has changed from stock_person to avatar-default Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=616822
(In reply to comment #9) > Created an attachment (id=166938) [details] [review] > Patch to use new icon names Approved. Can you also bump the minimum required gnome-icon-theme in configure.ac to 2.30.0?
commit 68341973d40b9ac5ffbc3f4132af0656194df13e Author: Rob Bradford <rob@linux.intel.com> Date: Mon Aug 2 11:08:48 2010 +0100 build: Update gnome-icon-theme dependency for new default-avatar icon commit b6b72b0c4a269333d5375e864a82e6b9588ffd07 Author: Rob Bradford <rob@linux.intel.com> Date: Sun Aug 1 19:29:56 2010 +0100 addressbook/gui, plugins/groupwise, widgets/misc: Update to new icon theme Since gnome-icon-theme 2.30.x the icon name for the default avatar has changed from stock_person to avatar-default Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=616822 All committed! Thanks!