After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616804 - [jpegdec] support more than 3 components
[jpegdec] support more than 3 components
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-25 23:25 UTC by Tim-Philipp Müller
Modified: 2018-11-03 14:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
jpegdec: rewrite colorspace/components checks (4.28 KB, patch)
2011-10-05 12:53 UTC, Vincent Penquerc'h
none Details | Review
jpegdec: test the correct colorspace (2.62 KB, patch)
2011-10-05 12:53 UTC, Vincent Penquerc'h
none Details | Review
jpegdec: decode YCCK images (7.61 KB, patch)
2011-10-05 12:53 UTC, Vincent Penquerc'h
none Details | Review

Description Tim-Philipp Müller 2010-04-25 23:25:46 UTC
+++ This bug was initially created as a clone of Bug #604106 +++

See attachment (id=149363)
Comment 1 Mark Nauwelaerts 2010-04-30 15:54:29 UTC
FWIW, just noting that libjpeg reports the colour space of this sample to be YCCK (definition?) as result of some decision heuristic.  As such, it is not only about components, but also colour space (including handling of some custom colour profiles or whatever).
Comment 2 Vincent Penquerc'h 2011-10-05 10:21:49 UTC
This seems to be a bastard of YCbCr and CMYK, where CMY are converted to YCbCr and K is written as is.
Comment 3 Vincent Penquerc'h 2011-10-05 12:53:20 UTC
Created attachment 198328 [details] [review]
jpegdec: rewrite colorspace/components checks

Use a table, for easier modification without having to write
custom checks for each case.
Comment 4 Vincent Penquerc'h 2011-10-05 12:53:23 UTC
Created attachment 198329 [details] [review]
jpegdec: test the correct colorspace

And store it for later so the "has it changed" test actually
does something.
While there, don't assume we get a YCbCr colorspace if it's
not grayscale nor RGB, test for it.
Comment 5 Vincent Penquerc'h 2011-10-05 12:53:26 UTC
Created attachment 198330 [details] [review]
jpegdec: decode YCCK images

I'm not totally sure that the decoding is correct on these two points:
- U and V need swapping to match the colors I get in Firefox, see
  the comment in the code
- Since K represents black, I think only Y is meant to be scaled,
  but I am not entirely certain
Comment 6 GStreamer system administrator 2018-11-03 14:41:48 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/27.