After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616693 - Cause expanding/collapsing a combo box to emit object:state-changed:showing
Cause expanding/collapsing a combo box to emit object:state-changed:showing
Status: RESOLVED FIXED
Product: java-atk-wrapper
Classification: Applications
Component: general
unspecified
Other opensolaris
: Normal enhancement
: ---
Assigned To: java-atk-wrapper maintainer(s)
java-atk-wrapper maintainer(s)
Depends on:
Blocks: orca-java
 
 
Reported: 2010-04-24 06:45 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2015-02-27 16:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
event log file (6.84 KB, text/plain)
2011-05-11 09:02 UTC, Leon Fan
  Details
patch to fix this issue (1.29 KB, patch)
2011-05-23 08:01 UTC, Leon Fan
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2010-04-24 06:45:59 UTC
Compare the following events from collapsing a combo box from both the SwingSet2 demo and gtk-demo:

object:state-changed:visible(0, 0, None)
	source: [popup menu | ]
	application: [application | SwingSet2]
	
================================================
	
object:state-changed:showing(0, 0, None)
	source: [menu | ]
	application: [application | gtk-demo]
object:state-changed:visible(0, 0, None)
	source: [menu | ]
	application: [application | gtk-demo]	

I have the Severity as 'enhancement' because the main issue for Orca in this regard is that, in general, we get tons of events. We try to avoid registering for what seems like redundant events because it's just more stuff to process that we don't need. We aren't registering for object:state-changed:visible because it always seems to come with object:state-changed:showing which we do register for.

What would be really, really nice from the Orca perspective is if the Java Atk Wrapper could emit both the visible and showing events. If this isn't doable, Orca can cope with what we are getting.

Thanks!
Comment 1 Leon Fan 2011-05-11 09:00:36 UTC
Joanmarie, I try to monitor the event for gtk-demo. Seemed visible and showing events won't emit together sometime, especially for windows(I enclosed one events log in attachment. Do you still prefer Java ATK Wrapper emit visible and showing both on all objects like this:

object:state-changed:showing(0, 0, None)
    source: [popup menu | ]
    application: [application | SwingSet2]

object:state-changed:visible(0, 0, None)
    source: [popup menu | ]
    application: [application | SwingSet2]

and 

object:state-changed:visible(1, 0, None)
    source: [popup menu | ]
    application: [application | SwingSet2]

object:state-changed:showing(1, 0, None)
    source: [popup menu | ]
    application: [application | SwingSet2]

I am not sure if it will bring any side effection current.
Comment 2 Leon Fan 2011-05-11 09:02:37 UTC
Created attachment 187613 [details]
event log file

Here is that event log file
Comment 3 Leon Fan 2011-05-23 08:01:55 UTC
Created attachment 188359 [details] [review]
patch to fix this issue
Comment 4 André Klapper 2012-02-26 10:41:54 UTC
[Resetting QA Contact to newly introduced "at-spi-maint@gnome.bugs". 
Reason: So far it was impossible to watch changes in at-spi bug reports without following all the specific persons (Li Yuan, Bill Haneman, Jeff Wai, ...) and also their activity outside of at-spi reports.

IMPORTANT: Anyone interested in following all bug activity (including all maintainers) must watch the "at-spi-maint@gnome.bugs" dummy user by adding it to the 'Users to watch' list under Preferences->Email preferences. This is also the default procedure nowadays in GNOME when setting up new products.]
Comment 5 André Klapper 2013-08-14 10:04:46 UTC
[Mass-resetting default assignee, see bug 705890. Please reclaim this bug report by setting the assignee to yourself if you still plan to work on this. Thanks!]
Comment 6 Magdalen Berns (irc magpie) 2014-11-08 19:29:19 UTC
Review of attachment 188359 [details] [review]:

It's been such a while since this patch was made that it no longer applies, unfortunately. Are you able to make a master compatible version for testing?
Comment 7 Magdalen Berns (irc magpie) 2014-12-31 18:20:01 UTC
Review of attachment 188359 [details] [review]:

On checking this again I see that this patch was actually already committed with https://git.gnome.org/browse/java-atk-wrapper/commit/wrapper/org/GNOME/Accessibility/AtkWrapper.java.in?id=5b0b399d0b7c7c6f8936d7fe3fcddc2de58c2972 and just not marked. I will close this.
Comment 8 André Klapper 2015-02-27 16:56:48 UTC
[Moving at-spi/java-atk-wrapper bugs to separate product. See bug 740075]