After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616586 - Use GObject's boxed type for GError
Use GObject's boxed type for GError
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.30
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-23 04:27 UTC by Sebastian Dröge (slomo)
Modified: 2010-04-29 16:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gst: Use GError boxed type from GObject 2.25.2 instead of our own if possible (1.10 KB, patch)
2010-04-23 04:27 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2010-04-23 04:27:23 UTC 
Hi,
attached patch uses GObject's boxed type for GError if possible. This was added in GObject 2.25.2.
Comment 1 Sebastian Dröge (slomo) 2010-04-23 04:27:45 UTC 
Created attachment 159386 [details] [review]
gst: Use GError boxed type from GObject 2.25.2 instead of our own if possible
Comment 2 Benjamin Otte (Company) 2010-04-23 09:50:09 UTC 
Should we add this into this core release?
Comment 3 Tim-Philipp Müller 2010-04-23 10:38:18 UTC 
> Should we add this into this core release?

I don't think this is particularly urgent, is it?

Besides, strictly speaking there is an element of ABI breakage here, since the type name changes and the old name disappears. I don't know of any code that looks up the type by name though, and unlike GstDate it's not serialisable, so it should probably be fine.
Comment 4 Benjamin Otte (Company) 2010-04-23 11:33:33 UTC 
Dunno. The problem arises when people start assuming that GST_TYPE_G_ERROR == G_TYPE_ERROR (and there is no way to check that equality other than runtime).

I'm not sure if people will ever assume this, but if they do, we'd better have it working right from day one.
Comment 5 Sebastian Dröge (slomo) 2010-04-29 16:19:12 UTC 
commit b748da35d62eed88aa8b0f4d605e43033f2615a0
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Fri Apr 23 06:24:56 2010 +0200

    gst: Use GError boxed type from GObject 2.25.2 instead of our own if possibl