GNOME Bugzilla – Bug 616459
Add needed fields to Orca's keyboardEvent and the ability to validate keyboardEvent Data
Last modified: 2010-09-20 10:52:06 UTC
This is a spin-off bug from bug 616206. While looking at the issues Alejandro was dealing with, and how he was dealing with them, in his work on Orca+Cally, I realized that we had very similar issues with Java (which I want to resolve sooner rather than later). Therefore, this bug separates out the changes needed in general for Orca's keyboardEvent. Bug 616206 will then focus on the Cally-specific work.
Created attachment 159295 [details] [review] proposed patch
Alex, I took what you had done and then added some changes to see if we can fix the Java issues. Sure enough, it worked. :-) The attached patch doesn't have the Java fixes; just the common stuff you need for what you're working on in Cally and what I need for Java. I'd appreciate your review. Thanks!
(In reply to comment #2) > Alex, I took what you had done and then added some changes to see if we can fix > the Java issues. Sure enough, it worked. :-) > > The attached patch doesn't have the Java fixes; just the common stuff you need > for what you're working on in Cally and what I need for Java. I'd appreciate > your review. After a quick review, it seems ok for me. As this have the common parts for Cally and Java, I will add a dependency between this bug and the mine, as I would need to update my patch. As far as I see, this bug is already blocking a JAVA one.
Comment on attachment 159295 [details] [review] proposed patch > After a quick review, it seems ok for me. Okie doke. Thanks! I also ran Orca's gtk-demo regression tests (the only part of the test suite which is updated for 2.30 *sigh*) and everything passed. Patch committed to master.