After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616243 - Swell Foop doesn´t save records
Swell Foop doesn´t save records
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: swell-foop
2.30.x
Other Linux
: Normal major
: ---
Assigned To: Jason Clinton
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-20 02:21 UTC by vamp898
Modified: 2012-07-15 01:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add missing highscores.add_score (395 bytes, patch)
2010-11-15 21:30 UTC, Edward Sheldrake 		none Details | Review
work around random score saving (1.70 KB, patch)
2010-11-17 14:18 UTC, Edward Sheldrake 		none Details | Review
better patch (833 bytes, patch)
2011-04-16 15:49 UTC, Edward Sheldrake 		none Details | Review

Description vamp898 2010-04-20 02:21:01 UTC 
i tried it on Archlinux, Gentoo and Ubuntu 10.04 Beta 2

Swell-Foop dont saves the record.
Comment 1 sly 2010-05-06 14:50:07 UTC 
i have the same situation.
Comment 2 Jesse Zhang 2010-05-30 14:26:01 UTC 
Same here (Foresight, 2.30.1).

I think swell-foop forgets to create the score files. For example quadrapassel does this:

install-data-local:
	-$(mkinstalldirs) $(DESTDIR)$(scoredir)
	-touch $(DESTDIR)$(scoredir)/quadrapassel.scores
	-chown $(scores_user):$(scores_group) $(DESTDIR)$(scoredir)/quadrapassel.scores
	-chmod 664 $(DESTDIR)$(scoredir)/quadrapassel.scores
Comment 3 Edward Sheldrake 2010-11-15 21:30:13 UTC 
Created attachment 174545 [details] [review]
add missing highscores.add_score

High score saving appears to be broken in several different ways: setgid permissions doesn't seem to work running under seed, after creating writeable score files, adding the missing line in the patch, the scores saved end up as random values.
Comment 4 Edward Sheldrake 2010-11-17 14:18:09 UTC 
Created attachment 174685 [details] [review]
work around random score saving

This works around the scores ending up random values.

It needs the win bonus patch to apply cleanly - I filed that separately as bug 635070
Comment 5 Edward Sheldrake 2011-04-16 15:49:41 UTC 
Created attachment 186081 [details] [review]
better patch

A better patch, for gnome-games 3.0.0. Doesn't solve the setgid problem, but it works if you chmod 666 the highscore files.
Comment 6 Robert Ancell 2012-07-15 01:25:38 UTC 
Seems to be working now, please re-open if still having problems in >3.4