GNOME Bugzilla – Bug 615294
Does not compile with -DGSEAL_ENABLE
Last modified: 2010-05-19 16:06:04 UTC
This module does not build with -DGSEAL_ENABLE. See http://live.gnome.org/GnomeGoals/UseGseal . Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing. Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.
Created attachment 158826 [details] [review] Partial patch Patch that fixes all issues except those that I am too stupid for (3 issues) and those that miss API in gtk+ (4 issues).
Grr, didn't notice you had posted a patch until I had already pushed a simliar commit: http://git.gnome.org/browse/gtkhtml/commit/?id=8d7db0b2135d039ebb969b67bbe05594705844ce I bumped the GTK+ requirement to 2.20. Didn't realize we had a solution for GtkAccessible now, so I'll get those hunks committed. And size_allocate() in gtkhtml.c is doing something insane with GtkLayout children that I need to take a closer look at.
Updated status on http://live.gnome.org/Evolution/GTK3.
Matt, I suppose you are on this.
Issue is still there. I'm marking patch as reviewd, because of Matthew's comment #2. Hopefully Matt will get to this soon.
Took a closer look at the GtkLayout issue and the best solution I can think of is instead of chaining up to GtkLayout's size_allocate() method with the children removed, just copy the logic directly into GtkHTML's size_allocate() method and remove the GtkLayoutChild processing loop. The rest of the logic doesn't seem to be accessing any internal GtkLayout members that we can't get to through its public API. I'll give this a shot, commit, and see how we do.
Fixed in http://git.gnome.org/browse/gtkhtml/commit/?id=4784f0a6a8fe23957917981152a61b402fa30bde Seems to work fine for me, further testing is encouraged.